Skip to content

Commit ce02e98

Browse files
committed
Removal of comment and debug print in test case
Signed-off-by: Jonathan Clohessy <jonathan.clohessy@arm.com>
1 parent 0c60f4e commit ce02e98

File tree

2 files changed

+0
-28
lines changed

2 files changed

+0
-28
lines changed

onnxruntime/core/mlas/lib/kleidiai/qgemm_kleidiai.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ ArmKleidiAI::MlasDynamicQGemmBatch(
122122
//to reverse the packing decision that was made for RHS.
123123

124124
ORT_ENFORCE(DataParams != nullptr, "Dynamic QGEMM requires valid DataParams.");
125-
// ORT_ENFORCE(Shape.K > 0, "Dynamic QGEMM requires Shape.K to be non-zero.");
126125

127126
for (size_t batch_idx = 0; batch_idx < BatchSize; ++batch_idx) {
128127
const auto& params = DataParams[batch_idx];

onnxruntime/test/mlas/unittest/test_dynamic_qgemm.cpp

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include "core/mlas/inc/mlas.h"
1010

1111
#include <cmath>
12-
#include <cstdlib>
1312
#include <limits>
1413

1514
class MlasDynamicQgemmTestBase {
@@ -165,37 +164,11 @@ class MlasDynamicQgemmTestBase {
165164
auto validate = [&](const char* tag) {
166165
SCOPED_TRACE(tag);
167166

168-
float max_diff = 0.0f;
169-
size_t max_i = 0;
170-
171167
for (size_t i = 0; i < M * N * BatchSize; ++i) {
172168
float abs_tol = 0.001f;
173169
float diff = std::abs(C[i] - CRef[i]);
174-
175-
if (diff > max_diff) {
176-
max_diff = diff;
177-
max_i = i;
178-
}
179-
180170
ASSERT_LE(diff, abs_tol);
181171
}
182-
183-
// Optional: print max diff for understanding margin vs tolerance.
184-
// Enable by setting MLAS_DYNQGEMM_REPORT_MAX_DIFF to any non-empty value.
185-
if (const char* env = std::getenv("MLAS_DYNQGEMM_REPORT_MAX_DIFF"); env && *env) {
186-
const size_t element_count = M * N * BatchSize;
187-
std::cerr << "[DynamicQGEMM] tag=" << tag
188-
<< " M=" << M << " N=" << N << " K=" << K << " B=" << BatchSize
189-
<< " max_diff=" << max_diff << " at_i=" << max_i;
190-
191-
if (element_count > 0 && max_i < element_count) {
192-
std::cerr << " C=" << C[max_i] << " CRef=" << CRef[max_i];
193-
} else {
194-
std::cerr << " (no element details; output is empty or index is out of range)";
195-
}
196-
197-
std::cerr << std::endl;
198-
}
199172
};
200173

201174
validate(run_tag);

0 commit comments

Comments
 (0)