Fix pytorch comparisonFix: Replace duplicate OpenVINO code with PyTorch code in comparison section#27019
Open
chaya2350 wants to merge 2 commits intomicrosoft:gh-pagesfrom
Open
Fix pytorch comparisonFix: Replace duplicate OpenVINO code with PyTorch code in comparison section#27019chaya2350 wants to merge 2 commits intomicrosoft:gh-pagesfrom
chaya2350 wants to merge 2 commits intomicrosoft:gh-pagesfrom
Conversation
…ction The 'Comparison with PyTorch' section was incorrectly showing OpenVINO code instead of PyTorch code. This fix uses the actual PyTorch model (resnet50) that was loaded earlier in the tutorial for comparison with ONNX Runtime. Fixes microsoft#25661
Author
|
@microsoft-github-policy-service agree |
Author
|
Hi! 👋 This documentation fix PR has been open for a week. Could someone please take a look? It's a small fix - the "Comparison with PyTorch" section was incorrectly showing OpenVINO code instead of actual PyTorch code. @danielzgtg - as the issue reporter, does this fix look correct to you? @skottmckay @jchen351 @justinchuby - could one of you please review when you have a moment? Thanks! 🙂 |
|
I confirm that this fixes my reported issue now that the duplication is gone. 👍 I will simply trust that your |
justinchuby
added
the
documentation
Author
|
@MaanavD @justinchuby |
The link https://aka.ms/onnx/modeltypes points to a Microsoft-internal SharePoint document that is not publicly accessible, causing CI link checks to fail with 404. This removes the broken link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Replace OpenVINO code with PyTorch code in PyTorch comparison section
The 'Comparison with PyTorch' section was incorrectly showing OpenVINO code instead of PyTorch code. This fix uses the actual PyTorch model (resnet50) that was loaded earlier in the tutorial for comparison with ONNX Runtime.
Fixes #25661
Description
The "Comparison with PyTorch" section incorrectly contained OpenVINO code instead of PyTorch code. Both the "Comparison with PyTorch" and "Comparison with OpenVINO" sections had identical code blocks, which was confusing for users following the tutorial.
This PR fixes the issue by:
resnet50PyTorch model that was already loaded earlier in the tutorialMotivation and Context
This change is required to fix a documentation bug where readers couldn't properly compare PyTorch performance with ONNX Runtime, as both comparison sections showed OpenVINO code.
Fixes #25661
The fix ensures that users following this tutorial can now correctly: