Skip to content

Commit bdc3981

Browse files
anass-bayamrserb
authored andcommitted
8361521: BogusFocusableWindowState.java fails with StackOverflowError on Linux
Reviewed-by: aivanov, serb
1 parent 9339a6a commit bdc3981

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,9 +1098,11 @@ public void setVisible(boolean vis) {
10981098
suppressWmTakeFocus(true);
10991099
}
11001100
}
1101-
updateFocusability();
1102-
promoteDefaultPosition();
11031101
boolean refreshChildsTransientFor = isVisible() != vis;
1102+
if (refreshChildsTransientFor) {
1103+
updateFocusability();
1104+
}
1105+
promoteDefaultPosition();
11041106
super.setVisible(vis);
11051107
if (refreshChildsTransientFor) {
11061108
for (Window child : ((Window) target).getOwnedWindows()) {

test/jdk/ProblemList.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java 8081489 generi
119119
java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java 6849364 generic-all
120120
java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java 6848406 generic-all
121121
java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java 6848407 generic-all
122-
java/awt/Frame/BogusFocusableWindowState/BogusFocusableWindowState.java 8361521 linux-all
123122
java/awt/Frame/MaximizedToMaximized/MaximizedToMaximized.java 8340374 macosx-all
124123
java/awt/Frame/MaximizedUndecorated/MaximizedUndecorated.java 8022302 generic-all
125124
java/awt/Frame/RestoreToOppositeScreen/RestoreToOppositeScreen.java 8286840 linux-all

test/jdk/java/awt/Frame/BogusFocusableWindowState/BogusFocusableWindowState.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
/**
2727
* @test
28-
* @bug 8346952
28+
* @bug 8346952 8361521
2929
* @summary Verifies no exception occurs when triggering updateCG()
3030
* for an ownerless window.
3131
* @key headful

0 commit comments

Comments
 (0)