Commit 4145e3d
fix(sdl): add expirationDate to guardian baseline result entries
#124 added the missing `createdDate` and cleared that error, but left
`expirationDate` off on purpose. The SDL policy rejects the entries for
exactly that:
##[error]Result with signature <76fd7a25...> on file
<guardian_baselines.gdnbaselines> is not compliant with the provided
policy. Reason: undefined. -- Additional arguments:You must provide a
valid expiration date for @microsoft/sdl/no-inner-html
`Baselined results: 0` and Guardian still exits 8, so the next publish
run on main failed the same way.
Both fields are required for this rule, not just `createdDate`. The
reasoning in #124 for omitting the expiry -- that a vendored bundle
should not need renewing -- is not available under this policy. Other
repositories under the same policy all carry an expiry, with windows of
90, 180 and 200 days.
Use 90 days, the shortest and most conservative of those.
This does mean the baseline lapses on 2026-11-27. Say so in the
justification so whoever hits it next has the context, and prefer an
ESLint path exclusion for `crates/cargo-gamma-lib/src/vendor/` as the
durable fix.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 17f0aea commit 4145e3d
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | | - | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
60 | 62 | | |
61 | 63 | | |
62 | 64 | | |
63 | | - | |
| 65 | + | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
0 commit comments