chore: address some net8.0 warnings (#2894)

Author: mxschmitt

src/Playwright/Core/BrowserContext.cs

@@ -45,7 +45,7 @@ internal class BrowserContext : ChannelOwner, IBrowserContext
     private readonly BrowserContextInitializer _initializer;
     private readonly Tracing _tracing;
     internal readonly IAPIRequestContext _request;
-    private readonly IDictionary<string, HarRecorder> _harRecorders = new Dictionary<string, HarRecorder>();
+    private readonly Dictionary<string, HarRecorder> _harRecorders = new();
     internal readonly List<IWorker> _serviceWorkers = new();
     private List<RouteHandler> _routes = new();
     internal readonly List<Page> _pages = new();
@@ -737,12 +737,12 @@ private async Task UnrouteInternalAsync(List<RouteHandler> removed, List<RouteHa
         await Task.WhenAll(tasks).ConfigureAwait(false);
     }
 
-    private Task UpdateInterceptionAsync()
+    private async Task UpdateInterceptionAsync()
     {
         var patterns = RouteHandler.PrepareInterceptionPatterns(_routes);
-        return SendMessageToServerAsync(
+        await SendMessageToServerAsync(
             "setNetworkInterceptionPatterns",
-            patterns);
+            patterns).ConfigureAwait(false);
     }
 
     internal void OnClose()
@@ -779,7 +779,7 @@ private void Channel_BindingCall(BindingCall bindingCall)
 
     private void Channel_Route(object sender, Route route) => _ = OnRouteAsync(route).ConfigureAwait(false);
 
-    private Task ExposeBindingAsync(string name, Delegate callback, bool handle = false)
+    private async Task ExposeBindingAsync(string name, Delegate callback, bool handle = false)
     {
         foreach (var page in _pages)
         {
@@ -796,13 +796,13 @@ private Task ExposeBindingAsync(string name, Delegate callback, bool handle = fa
 
         _bindings.Add(name, callback);
 
-        return SendMessageToServerAsync(
+        await SendMessageToServerAsync(
             "exposeBinding",
             new Dictionary<string, object>
             {
                 ["name"] = name,
                 ["needsHandle"] = handle,
-            });
+            }).ConfigureAwait(false);
     }
 
     private HarContentPolicy? RouteFromHarUpdateContentPolicyToHarContentPolicy(RouteFromHarUpdateContentPolicy? policy)

src/Playwright/Core/FormData.cs

@@ -37,7 +37,7 @@ public FormData()
 
     internal Dictionary<string, object> Values { get; }
 
-    private IFormData SetImpl(string name, object value)
+    private FormData SetImpl(string name, object value)
     {
         Values.Add(name, value);
         return this;

src/Playwright/Core/Frame.cs

@@ -528,9 +528,9 @@ public async Task SetInputFilesAsync(string selector, IEnumerable<FilePayload> f
         await _setInputFilesAsync(selector, converted, noWaitAfter: options?.NoWaitAfter, timeout: options?.Timeout, options?.Strict).ConfigureAwait(false);
     }
 
-    private Task _setInputFilesAsync(string selector, SetInputFilesFiles files, bool? noWaitAfter, float? timeout, bool? strict)
+    private async Task _setInputFilesAsync(string selector, SetInputFilesFiles files, bool? noWaitAfter, float? timeout, bool? strict)
     {
-        return SendMessageToServerAsync("setInputFiles", new Dictionary<string, object>
+        await SendMessageToServerAsync("setInputFiles", new Dictionary<string, object>
         {
             ["selector"] = selector,
             ["payloads"] = files.Payloads,
@@ -539,7 +539,7 @@ private Task _setInputFilesAsync(string selector, SetInputFilesFiles files, bool
             ["noWaitAfter"] = noWaitAfter,
             ["timeout"] = timeout,
             ["strict"] = strict,
-        });
+        }).ConfigureAwait(false);
     }
 
     [MethodImpl(MethodImplOptions.NoInlining)]

src/Playwright/Core/Page.cs

@@ -1266,10 +1266,10 @@ private async Task UnrouteInternalAsync(List<RouteHandler> removed, List<RouteHa
         await Task.WhenAll(tasks).ConfigureAwait(false);
     }
 
-    private Task UpdateInterceptionAsync()
+    private async Task UpdateInterceptionAsync()
     {
         var patterns = RouteHandler.PrepareInterceptionPatterns(_routes);
-        return SendMessageToServerAsync("setNetworkInterceptionPatterns", patterns);
+        await SendMessageToServerAsync("setNetworkInterceptionPatterns", patterns).ConfigureAwait(false);
     }
 
     internal void OnClose()
@@ -1352,7 +1352,7 @@ private void Channel_FrameAttached(object sender, IFrame args)
         FrameAttached?.Invoke(this, args);
     }
 
-    private Task InnerExposeBindingAsync(string name, Delegate callback, bool handle = false)
+    private async Task InnerExposeBindingAsync(string name, Delegate callback, bool handle = false)
     {
         if (Bindings.ContainsKey(name))
         {
@@ -1361,13 +1361,13 @@ private Task InnerExposeBindingAsync(string name, Delegate callback, bool handle
 
         Bindings.Add(name, callback);
 
-        return SendMessageToServerAsync(
+        await SendMessageToServerAsync(
             "exposeBinding",
             new Dictionary<string, object>
             {
                 ["name"] = name,
                 ["needsHandle"] = handle,
-            });
+            }).ConfigureAwait(false);
     }
 
     private Video ForceVideo() => _video ??= new(this, _connection);

src/Playwright/Helpers/SetInputFilesHelpers.cs

@@ -63,7 +63,7 @@ public static async Task<SetInputFilesFiles> ConvertInputFilesAsync(IEnumerable<
             }).ConfigureAwait(false);
             return new() { Streams = streams.ToArray() };
         }
-        return new() { LocalPaths = files.Select(f => Path.GetFullPath(f)).ToArray() };
+        return new() { LocalPaths = files.Select(Path.GetFullPath).ToArray() };
     }
 
     public static SetInputFilesFiles ConvertInputFiles(IEnumerable<FilePayload> files)

src/Playwright/Helpers/StringExtensions.cs

@@ -37,7 +37,7 @@ internal static class StringExtensions
     // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions#escaping
     private static readonly char[] _escapeGlobChars = new[] { '$', '^', '+', '.', '*', '(', ')', '|', '\\', '?', '{', '}', '[', ']' };
 
-    private static readonly IDictionary<string, string> _mappings = new Dictionary<string, string>(StringComparer.InvariantCultureIgnoreCase)
+    private static readonly Dictionary<string, string> _mappings = new Dictionary<string, string>(StringComparer.InvariantCultureIgnoreCase)
         {
             { ".323", "text/h323" },
             { ".3g2", "video/3gpp2" },

src/Playwright/Transport/Converters/EvaluateArgumentValueConverter.cs

@@ -365,7 +365,7 @@ private static object ParseEvaluateResultToExpando(JsonElement result, IDictiona
 
         if (result.TryGetProperty("a", out var array))
         {
-            IList<object> list = new List<object>();
+            List<object> list = new List<object>();
             refs.Add(result.GetProperty("id").GetInt32(), list);
             foreach (var item in array.EnumerateArray())
             {