chore: avoid typed StorageState

dgozman · dgozman · commit 9f70f2102f3f · 2025-03-04T11:41:08.000Z
This port should treat it as an opaque json object.
diff --git a/src/Playwright/Core/APIRequest.cs b/src/Playwright/Core/APIRequest.cs
@@ -64,7 +64,7 @@ async Task<IAPIRequestContext> IAPIRequest.NewContextAsync(APIRequestNewContextO
         }
         if (!string.IsNullOrEmpty(storageState))
         {
-            args.Add("storageState", JsonSerializer.Deserialize<StorageState>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));
+            args.Add("storageState", JsonSerializer.Deserialize<object>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));
         }
 
         var context = await _playwright.SendMessageToServerAsync<APIRequestContext>(
diff --git a/src/Playwright/Core/APIRequestContext.cs b/src/Playwright/Core/APIRequestContext.cs
@@ -215,7 +215,7 @@ private APIRequestContextOptions WithMethod(APIRequestContextOptions options, st
     public async Task<string> StorageStateAsync(APIRequestContextStorageStateOptions options = null)
     {
         string state = JsonSerializer.Serialize(
-            await SendMessageToServerAsync<StorageState>("storageState").ConfigureAwait(false),
+            await SendMessageToServerAsync<object>("storageState").ConfigureAwait(false),
             JsonExtensions.DefaultJsonSerializerOptions);
 
         if (!string.IsNullOrEmpty(options?.Path))
diff --git a/src/Playwright/Core/Browser.cs b/src/Playwright/Core/Browser.cs
@@ -155,7 +155,7 @@ public async Task<IBrowserContext> NewContextAsync(BrowserNewContextOptions opti
 
         if (!string.IsNullOrEmpty(storageState))
         {
-            args.Add("storageState", JsonSerializer.Deserialize<StorageState>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));
+            args.Add("storageState", JsonSerializer.Deserialize<object>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));
         }
 
         if (options.ViewportSize?.Width == -1)
diff --git a/src/Playwright/Core/BrowserContext.cs b/src/Playwright/Core/BrowserContext.cs
@@ -539,7 +539,7 @@ public Task SetOfflineAsync(bool offline) => SendMessageToServerAsync(
     public async Task<string> StorageStateAsync(BrowserContextStorageStateOptions options = default)
     {
         string state = JsonSerializer.Serialize(
-            await SendMessageToServerAsync<StorageState>("storageState").ConfigureAwait(false),
+            await SendMessageToServerAsync<object>("storageState").ConfigureAwait(false),
             JsonExtensions.DefaultJsonSerializerOptions);
 
         if (!string.IsNullOrEmpty(options?.Path))
diff --git a/src/Playwright/Core/StorageState.cs b/src/Playwright/Core/StorageState.cs

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ async Task<IAPIRequestContext> IAPIRequest.NewContextAsync(APIRequestNewContextO`
`64`	`64`	`}`
`65`	`65`	`if (!string.IsNullOrEmpty(storageState))`
`66`	`66`	`{`
`67`		`- args.Add("storageState", JsonSerializer.Deserialize<StorageState>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));`
	`67`	`+ args.Add("storageState", JsonSerializer.Deserialize<object>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`var context = await _playwright.SendMessageToServerAsync<APIRequestContext>(`
Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ private APIRequestContextOptions WithMethod(APIRequestContextOptions options, st`
`215`	`215`	`public async Task<string> StorageStateAsync(APIRequestContextStorageStateOptions options = null)`
`216`	`216`	`{`
`217`	`217`	`string state = JsonSerializer.Serialize(`
`218`		`- await SendMessageToServerAsync<StorageState>("storageState").ConfigureAwait(false),`
	`218`	`+ await SendMessageToServerAsync<object>("storageState").ConfigureAwait(false),`
`219`	`219`	`JsonExtensions.DefaultJsonSerializerOptions);`
`220`	`220`
`221`	`221`	`if (!string.IsNullOrEmpty(options?.Path))`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public async Task<IBrowserContext> NewContextAsync(BrowserNewContextOptions opti`
`155`	`155`
`156`	`156`	`if (!string.IsNullOrEmpty(storageState))`
`157`	`157`	`{`
`158`		`- args.Add("storageState", JsonSerializer.Deserialize<StorageState>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));`
	`158`	`+ args.Add("storageState", JsonSerializer.Deserialize<object>(storageState, Helpers.JsonExtensions.DefaultJsonSerializerOptions));`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`if (options.ViewportSize?.Width == -1)`
Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,7 @@ public Task SetOfflineAsync(bool offline) => SendMessageToServerAsync(`
`539`	`539`	`public async Task<string> StorageStateAsync(BrowserContextStorageStateOptions options = default)`
`540`	`540`	`{`
`541`	`541`	`string state = JsonSerializer.Serialize(`
`542`		`- await SendMessageToServerAsync<StorageState>("storageState").ConfigureAwait(false),`
	`542`	`+ await SendMessageToServerAsync<object>("storageState").ConfigureAwait(false),`
`543`	`543`	`JsonExtensions.DefaultJsonSerializerOptions);`
`544`	`544`
`545`	`545`	`if (!string.IsNullOrEmpty(options?.Path))`