chore: ignore GitHub Codespaces BROWSER env var (#3068)

mxschmitt · web-flow · commit df5985459d4e · 2024-12-05T10:34:14.000-08:00
diff --git a/src/Playwright.TestAdapter/PlaywrightSettingsProvider.cs b/src/Playwright.TestAdapter/PlaywrightSettingsProvider.cs
@@ -40,7 +40,9 @@ public static string BrowserName
         get
         {
             var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant();
-            if (!string.IsNullOrEmpty(browserFromEnv))
+            // GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus.
+            var ignoreValueFromEnv = Environment.GetEnvironmentVariable("CODESPACES") == "true" && browserFromEnv!.StartsWith("/vscode/");
+            if (!string.IsNullOrEmpty(browserFromEnv) && !ignoreValueFromEnv)
             {
                 ValidateBrowserName(browserFromEnv!, "'BROWSER' environment variable", "\nTry to remove 'BROWSER' environment variable for using default browser");
                 return browserFromEnv!;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,9 @@ public static string BrowserName`
`40`	`40`	`get`
`41`	`41`	`{`
`42`	`42`	`var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant();`
`43`		`- if (!string.IsNullOrEmpty(browserFromEnv))`
	`43`	`+ // GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus.`
	`44`	`+ var ignoreValueFromEnv = Environment.GetEnvironmentVariable("CODESPACES") == "true" && browserFromEnv!.StartsWith("/vscode/");`
	`45`	`+ if (!string.IsNullOrEmpty(browserFromEnv) && !ignoreValueFromEnv)`
`44`	`46`	`{`
`45`	`47`	`ValidateBrowserName(browserFromEnv!, "'BROWSER' environment variable", "\nTry to remove 'BROWSER' environment variable for using default browser");`
`46`	`48`	`return browserFromEnv!;`