Skip to content

Commit 1dd206e

Browse files
committed
chore(chromium): re-enable PlzDedicatedWorker feature
With the latest stable, all problems should have been fixed.
1 parent 24f06ec commit 1dd206e

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

packages/playwright-core/src/server/chromium/chromiumSwitches.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,10 @@ export const chromiumSwitches = [
3737
// PaintHolding - https://github.com/microsoft/playwright/issues/28023
3838
// ThirdPartyStoragePartitioning - https://github.com/microsoft/playwright/issues/32230
3939
// LensOverlay - Hides the Lens feature in the URL address bar. Its not working in unofficial builds.
40-
// PlzDedicatedWorker - https://github.com/microsoft/playwright/issues/31747
4140
// DeferRendererTasksAfterInput - this makes Page.frameScheduledNavigation arrive much later after a click,
4241
// making our navigation auto-wait after click not working. Can be removed once we deperecate noWaitAfter.
4342
// See https://github.com/microsoft/playwright/pull/34372.
44-
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,ThirdPartyStoragePartitioning,LensOverlay,PlzDedicatedWorker,DeferRendererTasksAfterInput',
43+
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync,Translate,HttpsUpgrades,PaintHolding,ThirdPartyStoragePartitioning,LensOverlay,DeferRendererTasksAfterInput',
4544
'--allow-pre-commit-input',
4645
'--disable-hang-monitor',
4746
'--disable-ipc-flooding-protection',

tests/page/interception.spec.ts

-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ it('should intercept worker requests when enabled after worker creation', {
126126
}, async ({ page, server, isAndroid, browserName, browserMajorVersion }) => {
127127
it.skip(isAndroid);
128128
it.skip(browserName === 'chromium' && browserMajorVersion < 130, 'fixed in Chromium 130');
129-
it.fixme(browserName === 'chromium', 'requires PlzDedicatedWorker to be enabled');
130129

131130
await page.goto(server.EMPTY_PAGE);
132131
server.setRoute('/data_for_worker', (req, res) => res.end('failed to intercept'));

0 commit comments

Comments
 (0)