test: fix a few tests (#39840)

Author: dgozman

packages/playwright-core/src/server/firefox/ffPage.ts

@@ -477,7 +477,7 @@ export class FFPage implements PageDelegate {
   }
 
   async startScreencast(options: { width: number, height: number, quality: number }): Promise<void> {
-    await this._session.send('Page.startScreencast', options);
+    await this._session.send('Page.startScreencast', { width: options.width, height: options.height, quality: options.quality });
   }
 
   async stopScreencast(): Promise<void> {

tests/config/commonFixtures.ts

@@ -19,7 +19,7 @@ import type { ChildProcess } from 'child_process';
 import { execSync, spawn } from 'child_process';
 import net from 'net';
 import fs from 'fs';
-import { stripAnsi } from './utils';
+import { inheritAndCleanEnv, stripAnsi } from './utils';
 
 type TestChildParams = {
   command: string[],
@@ -111,10 +111,7 @@ export class TestChildProcess {
     const command = params.shell ? params.command.join(' ') : params.command[0];
     const args = params.shell ? [] : params.command.slice(1);
     this.process = spawn(command, args, {
-      env: {
-        ...process.env,
-        ...params.env,
-      },
+      env: inheritAndCleanEnv(params.env),
       cwd: params.cwd,
       shell: params.shell,
       // On non-windows platforms, `detached: true` makes child process a leader of a new

tests/config/remoteServer.ts

@@ -15,6 +15,7 @@
  */
 
 import path from 'path';
+import { inheritAndCleanEnv } from './utils';
 import type { BrowserType, Browser } from 'playwright-core';
 import type { CommonFixtures, TestChildProcess } from './commonFixtures';
 
@@ -35,10 +36,7 @@ export class RunServer implements PlaywrightServer {
       command.push(`--artifacts-dir=${options.artifactsDir}`);
     this._process = childProcess({
       command,
-      env: {
-        ...process.env,
-        ...options?.env,
-      },
+      env: inheritAndCleanEnv(options?.env),
     });
 
     let wsEndpointCallback: (value: string) => void;

tests/config/utils.ts

@@ -229,3 +229,35 @@ const ansiRegex = new RegExp('[\\u001B\\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(
 export function stripAnsi(str: string): string {
   return str.replace(ansiRegex, '');
 }
+
+export function inheritAndCleanEnv(env: NodeJS.ProcessEnv | undefined): NodeJS.ProcessEnv {
+  return {
+    ...process.env,
+    // BEGIN: Reserved CI
+    CI: undefined,
+    BUILD_URL: undefined,
+    CI_COMMIT_SHA: undefined,
+    CI_JOB_URL: undefined,
+    CI_PROJECT_URL: undefined,
+    GITHUB_ACTIONS: undefined,
+    GITHUB_REPOSITORY: undefined,
+    GITHUB_RUN_ID: undefined,
+    GITHUB_SERVER_URL: undefined,
+    GITHUB_SHA: undefined,
+    GITHUB_EVENT_PATH: undefined,
+    // END: Reserved CI
+    PW_TEST_HTML_REPORT_OPEN: undefined,
+    PLAYWRIGHT_HTML_OPEN: undefined,
+    PW_TEST_DEBUG_REPORTERS: undefined,
+    PW_TEST_REPORTER: undefined,
+    PW_TEST_REPORTER_WS_ENDPOINT: undefined,
+    PW_TEST_SOURCE_TRANSFORM: undefined,
+    PW_TEST_SOURCE_TRANSFORM_SCOPE: undefined,
+    PWTEST_BOT_NAME: undefined,
+    PWTEST_SHARD_WEIGHTS: undefined,
+    TEST_WORKER_INDEX: undefined,
+    TEST_PARALLEL_INDEX: undefined,
+    NODE_OPTIONS: undefined,
+    ...env,
+  };
+}

tests/electron/electronTest.ts

@@ -23,6 +23,7 @@ import type { PageTestFixtures, PageWorkerFixtures } from '../page/pageTestApi';
 import type { TraceViewerFixtures } from '../config/traceViewerFixtures';
 import { traceViewerFixtures } from '../config/traceViewerFixtures';
 import { removeFolders } from '../../packages/playwright-core/lib/server/utils/fileUtils';
+import { inheritAndCleanEnv } from '../config/utils';
 export { expect } from '@playwright/test';
 
 type ElectronTestFixtures = PageTestFixtures & {
@@ -63,10 +64,7 @@ export const electronTest = baseTest.extend<TraceViewerFixtures>(traceViewerFixt
       const app = await playwright._electron.launch({
         ...options,
         args: [path.join(__dirname, appFile), ...args],
-        env: {
-          ...process.env,
-          PWTEST_ELECTRON_USER_DATA_DIR: userDataDir,
-        }
+        env: inheritAndCleanEnv({ PWTEST_ELECTRON_USER_DATA_DIR: userDataDir }),
       });
       apps.push(app);
       return app;

tests/library/browsercontext-locale.spec.ts

@@ -171,13 +171,13 @@ it('should propagate locale to workers', async ({ browser, browserName, server }
   const page = await context.newPage();
   await page.goto(server.EMPTY_PAGE);
   const [msg] = await Promise.all([
-    page.waitForEvent('console'),
-    page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(Intl.NumberFormat().resolvedOptions().locale)'], { type: 'application/javascript' })))),
+    page.waitForEvent('console', e => e.text().startsWith('locale:')),
+    page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log("locale:" + Intl.NumberFormat().resolvedOptions().locale)'], { type: 'application/javascript' })))),
   ]);
   if (browserName === 'webkit')
-    expect(msg.text()).toContain('ru'); // Webkit on Ubuntu is "ru-RU", and on other platforms is "ru"
+    expect(msg.text()).toContain('locale:ru'); // Webkit on Ubuntu is "ru-RU", and on other platforms is "ru"
   else
-    expect(msg.text()).toBe('ru-RU');
+    expect(msg.text()).toBe('locale:ru-RU');
   await context.close();
 });
 

tests/library/browsercontext-reuse.spec.ts

@@ -371,7 +371,7 @@ for (const scenario of ['launch', 'connect'] as const) {
           });
           server.onMessage(message => ws.send(message));
         });
-        await page.goto('about:blank');
+        await page.goto(server.EMPTY_PAGE);
         await page.evaluate(host => {
           window.log = [];
           (window as any).ws1 = new WebSocket('ws://' + host + '/ws1');

tests/library/firefox/launcher.spec.ts

@@ -17,6 +17,7 @@
 import fs from 'fs';
 import { playwrightTest as it, expect } from '../../config/browserTest';
 import { TestServer } from '../../config/testserver';
+import { inheritAndCleanEnv } from '../../config/utils';
 
 it('should pass firefox user preferences', async ({ browserType, mode }) => {
   it.skip(mode.startsWith('service'));
@@ -67,7 +68,7 @@ it('should support custom firefox policies', async ({ browserType, mode, asset,
   await server.waitUntilReady();
 
   const browser = await browserType.launch({
-    env: { ...process.env, 'PLAYWRIGHT_FIREFOX_POLICIES_JSON': policiesPath },
+    env: inheritAndCleanEnv({ 'PLAYWRIGHT_FIREFOX_POLICIES_JSON': policiesPath }),
   });
 
   const page = await browser.newPage();

tests/library/launcher.spec.ts

@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import { inheritAndCleanEnv } from '../config/utils';
 import { playwrightTest as it, expect } from '../config/browserTest';
 
 it('should have an errors object', async ({ playwright }) => {
@@ -49,10 +50,7 @@ it('should throw a friendly error if its headed and there is no xserver on linux
 
   const error: Error = await browserType.launch({
     headless: false,
-    env: {
-      ...process.env,
-      DISPLAY: undefined,
-    },
+    env: inheritAndCleanEnv({ DISPLAY: undefined }),
   }).catch(e => e);
   expect(error).toBeInstanceOf(Error);
   expect(error.message).toMatch(/Looks like you launched a headed browser without having a XServer running./);

tests/library/route-web-socket.spec.ts

@@ -258,7 +258,7 @@ test('should pattern match', async ({ page, server }) => {
 
   const wsPromise = server.waitForWebSocket();
 
-  await page.goto('about:blank');
+  await page.goto(server.EMPTY_PAGE);
   await page.evaluate(async ({ host }) => {
     window.log = [];
     (window as any).ws1 = new WebSocket('ws://' + host + '/ws');
@@ -475,7 +475,7 @@ test('should route on context', async ({ page, server }) => {
     });
   });
 
-  await page.goto('about:blank');
+  await page.goto(server.EMPTY_PAGE);
   await page.evaluate(({ host }) => {
     window.log = [];
     (window as any).ws1 = new WebSocket('ws://' + host + '/ws1');
@@ -542,7 +542,7 @@ test('should work with no trailing slash', async ({ page, server }) => {
     });
   });
 
-  await page.goto('about:blank');
+  await page.goto(server.EMPTY_PAGE);
   await page.evaluate(({ host }) => {
     window.log = [];
     // No trailing slash!