Skip to content

Commit 2b2db9b

Browse files
committed
docs(cli-client/skill): fix small typos in skill references
- spec-driven-testing.md: `Singing in and out` → `Signing in and out` - storage-state.md: bump example cookie `expires` from 1735689600 (Jan 1, 2025) to 1893456000 (Jan 1, 2030) so the example doesn't read as already-expired - video-recording.md: `pulling appropriate pauses` → `inserting appropriate pauses` Same fixes were originally opened as microsoft/playwright-cli#412; @dgozman pointed out this is the source of truth, redoing it here.
1 parent b949df5 commit 2b2db9b

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/playwright-core/src/tools/cli-client/skill/references/spec-driven-testing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ Collect the generated code and write the test file at the path given in the spec
191191
// seed: tests/seed.spec.ts
192192
import { test, expect } from './fixtures'; // or '@playwright/test' if no fixtures file
193193

194-
test.describe('Singing in and out', () => {
194+
test.describe('Signing in and out', () => {
195195
test('should sign in', async ({ page }) => {
196196
// 1. Navigate to the application
197197
// (handled by the seed fixture)

packages/playwright-core/src/tools/cli-client/skill/references/storage-state.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ The saved file contains:
3838
"value": "abc123",
3939
"domain": "example.com",
4040
"path": "/",
41-
"expires": 1735689600,
41+
"expires": 1893456000,
4242
"httpOnly": true,
4343
"secure": true,
4444
"sameSite": "Lax"
@@ -92,7 +92,7 @@ playwright-cli cookie-set session abc123
9292
playwright-cli cookie-set session abc123 --domain=example.com --path=/ --httpOnly --secure --sameSite=Lax
9393

9494
# Cookie with expiration (Unix timestamp)
95-
playwright-cli cookie-set remember_me token123 --expires=1735689600
95+
playwright-cli cookie-set remember_me token123 --expires=1893456000
9696
```
9797

9898
### Delete a Cookie

packages/playwright-core/src/tools/cli-client/skill/references/video-recording.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ playwright-cli video-start recordings/checkout-test-run-42.webm
4040
### 2. Record entire hero scripts.
4141

4242
When recording a video for the user or as a proof of work, it is best to create a code snippet and execute it with run-code.
43-
It allows pulling appropriate pauses between the actions and annotating the video. There are new Playwright APIs for that.
43+
It allows inserting appropriate pauses between the actions and annotating the video. There are new Playwright APIs for that.
4444

4545
1) Perform scenario using CLI and take note of all locators and actions. You'll need those locators to request their bounding boxes for highlight.
4646
2) Create a file with the intended script for video (below). Use pressSequentially w/ delay for nice typing, make reasonable pauses.

0 commit comments

Comments
 (0)