review feedback

Author: mxschmitt

docs/src/api/class-locatorassertions.md

@@ -1443,19 +1443,21 @@ Ensures the [Locator] points to an element with given CSS classes. When a string
 const locator = page.locator('#component');
 await expect(locator).toHaveClass('middle selected row');
 await expect(locator).toHaveClass('selected', { partial: true });
+await expect(locator).toHaveClass('middle row', { partial: true });
 ```
 
 ```java
 assertThat(page.locator("#component")).hasClass("middle selected row");
 assertThat(page.locator("#component")).hasClass("selected", new LocatorAssertions.HasClassOptions().setPartial(true));
+assertThat(page.locator("#component")).hasClass("middle row", new LocatorAssertions.HasClassOptions().setPartial(true));
 ```
 
 ```python async
 from playwright.async_api import expect
 
 locator = page.locator("#component")
 await expect(locator).to_have_class("middle selected row")
-await expect(locator).to_have_class("selected", partial=True)
+await expect(locator).to_have_class("middle row", partial=True)
 ```
 
 ```python sync
@@ -1464,12 +1466,14 @@ from playwright.sync_api import expect
 locator = page.locator("#component")
 expect(locator).to_have_class("middle selected row")
 expect(locator).to_have_class("selected", partial=True)
+expect(locator).to_have_class("middle row", partial=True)
 ```
 
 ```csharp
 var locator = Page.Locator("#component");
 await Expect(locator).ToHaveClassAsync("middle selected row");
 await Expect(locator).ToHaveClassAsync("selected", new() { Partial = true });
+await Expect(locator).ToHaveClassAsync("middle row", new() { Partial = true });
 ```
 
 When an array is passed, the method asserts that the list of elements located matches the corresponding list of expected class values. Each element's class attribute is matched against the corresponding string or regular expression in the array:

packages/playwright-core/src/server/injected/injectedScript.ts

@@ -1398,9 +1398,11 @@ export class InjectedScript {
           return { received: null, matches: false };
         received = value;
       } else if (expression === 'to.have.class') {
+        if (!options.expectedText)
+          throw this.createStacklessError('Expected text is not provided for ' + expression);
         return {
           received: element.classList.toString(),
-          matches: new ExpectedTextMatcher(options.expectedText![0]).matchesClassList(element.classList, options.expressionArg.partial),
+          matches: new ExpectedTextMatcher(options.expectedText[0]).matchesClassList(this, element.classList, options.expressionArg.partial),
         };
       } else if (expression === 'to.have.css') {
         received = this.window.getComputedStyle(element).getPropertyValue(options.expressionArg);
@@ -1455,7 +1457,7 @@ export class InjectedScript {
       if (receivedClassLists.length !== options.expectedText.length)
         return { received, matches: false };
       const matches = this._matchSequentially(options.expectedText, receivedClassLists, (matcher, r) =>
-        matcher.matchesClassList(r, options.expressionArg.partial)
+        matcher.matchesClassList(this, r, options.expressionArg.partial)
       );
       return {
         received: received,
@@ -1647,10 +1649,10 @@ class ExpectedTextMatcher {
     return false;
   }
 
-  matchesClassList(classList: DOMTokenList, partial: boolean): boolean {
+  matchesClassList(injectedScript: InjectedScript, classList: DOMTokenList, partial: boolean): boolean {
     if (partial) {
       if (this._regex)
-        throw new Error('Partial matching does not support regular expressions. Please provide a string value.');
+        throw injectedScript.createStacklessError('Partial matching does not support regular expressions. Please provide a string value.');
       return this._string!.split(/\s+/g).filter(Boolean).every(className => classList.contains(className));
     }
     return this.matches(classList.toString());

packages/playwright/types/test.d.ts

@@ -8410,6 +8410,7 @@ interface LocatorAssertions {
    * const locator = page.locator('#component');
    * await expect(locator).toHaveClass('middle selected row');
    * await expect(locator).toHaveClass('selected', { partial: true });
+   * await expect(locator).toHaveClass('middle row', { partial: true });
    * ```
    *
    * When an array is passed, the method asserts that the list of elements located matches the corresponding list of

tests/page/expect-misc.spec.ts

@@ -232,6 +232,7 @@ test.describe('toHaveClass', () => {
     await expect(locator).not.toHaveClass('foo');
     await expect(locator).not.toHaveClass('foo', { partial: false });
     await expect(locator).toHaveClass('  bar   foo ', { partial: true });
+    await expect(locator).not.toHaveClass('does-not-exist', { partial: true });
     await expect(locator).not.toHaveClass('  baz   foo ', { partial: true }); // Strip whitespace and match individual classes
   });
 
@@ -241,7 +242,7 @@ test.describe('toHaveClass', () => {
     await expect(locator).toHaveClass(['aaa', 'b2b', 'ccc'], { partial: true });
     await expect(locator).not.toHaveClass(['aaa', 'b2b', 'ccc']);
     await expect(
-        expect(locator).toHaveClass([/b2?ar/], { partial: true })
+        expect(locator).toHaveClass([/b2?ar/, /b2?ar/, /b2?ar/], { partial: true })
     ).rejects.toThrow('Partial matching does not support regular expressions. Please provide a string value.');
     await expect(locator).not.toHaveClass(['aaa', 'b2b', 'ccc'], { partial: false });
     await expect(locator).not.toHaveClass(['not-there', 'b2b', 'ccc'], { partial: true }); // Class not there