chore: do not show steps in line reporter without tty (#34529)

microsoft · Jan 29, 2025 · 4b5b326 · 4b5b326
1 parent f15171b
commit 4b5b326
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/playwright/src/reporters/line.ts b/packages/playwright/src/reporters/line.ts
@@ -68,12 +68,12 @@ class LineReporter extends TerminalReporter {
   }
 
   onStepBegin(test: TestCase, result: TestResult, step: TestStep) {
-    if (step.category === 'test.step')
+    if (this.screen.isTTY && step.category === 'test.step')
       this._updateLine(test, result, step);
   }
 
   onStepEnd(test: TestCase, result: TestResult, step: TestStep) {
-    if (step.category === 'test.step')
+    if (this.screen.isTTY && step.category === 'test.step')
       this._updateLine(test, result, step.parent);
   }
 

diff --git a/tests/playwright-test/reporter-line.spec.ts b/tests/playwright-test/reporter-line.spec.ts
@@ -125,7 +125,7 @@ for (const useIntermediateMergeReport of [false, true] as const) {
             });
           });
         `,
-      }, { reporter: 'line' });
+      }, { reporter: 'line' }, { PLAYWRIGHT_FORCE_TTY: '1' });
       const text = result.output;
       expect(text).toContain('[1/1] a.test.ts:3:15 › passes › outer › inner');
       expect(result.exitCode).toBe(0);