playwright-test/(json-reporter) - add tags to suite

[klh]

https://github.com/microsoft/playwright/blob/15b9e5afdb82b2c372ce5dc0adc18540bb950d53/packages/playwright-test/src/reporters/json.ts#L156C7-L156C7

htmlreporter has added support for extracting tags from suite titles (describe("my thing @tag",{}=>())

json reporter should probably do the same.
There is also a valid point in not only extracting them, but also removing them from the title after they have been added to a new tags: [] for the suite

[aslushnikov]

@klh HTML reporter uses tags for presentation purposes.

JSON reporter, on the other hand, is only consumed programmatically. What exactly do you mean by "supporting tags" for JSON reporter?

[klh]

When creating a json report
The individual tests will have a tags: [], object that contains the test titles tags inside it.

That is not the case for the suite title (describe())

Which i recon it should be.

In addition tags should probably be removed fron the title post processing IF theyre moved to tags

[aslushnikov]

That is not the case for the suite title (describe())

@klh looks like a bug then; we're open to a pull request!

In addition tags should probably be removed fron the title post processing IF theyre moved to tags

This would be a breaking change that we can't afford.

[klh]

looking in

That is not the case for the suite title (describe())

@klh looks like a bug then; we're open to a pull request!

looking into it

[klh]

That is not the case for the suite title (describe())

@klh looks like a bug then; we're open to a pull request!

In addition tags should probably be removed fron the title post processing IF theyre moved to tags

This would be a breaking change that we can't afford.

trying to keep this PR alive, its ready to merge and builds as it should (your actions are flaky).
could you please merge this - #24515
@aslushnikov

[aslushnikov]

Hey @klh,

The team decided to investigate a native tags support - tracked in #26327
So landing this PR is blocked on the results of the investigation. We'll hopefully see how it goes by 1.38

[klh]

Why not just merge this interim, its a tiny change and it fixes the bug.Den 15. aug. 2023 kl. 15.55 skrev Andrey Lushnikov ***@***.***>: Hey @klh, The team decided to investigate a native tags support - tracked in #26327 So landing this PR is blocked on the results of the investigation. We'll hopefully see how it goes by 1.38 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>