Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): generate multiple selectors to choose from #29154

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 24, 2024

When possible, "pick locator" generates:

  • default locator;
  • locator without any text;
  • locator without css #id.

Fixes #27875, fixes #5178.

When possible, "pick locator" generates:
- default locator;
- locator without any text;
- locator without css `#id`.
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › playwright-component-testing.spec.ts:21:5 › pnpm: @playwright/experimental-ct-react should work

3 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21355 passed, 579 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit f5de6e5 into microsoft:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants