Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chromium): pass --enable-gpu when running headless #30937

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix(chromium): pass --enable-gpu when running headless #30937

merged 1 commit into from
Jun 13, 2024

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented May 21, 2024 •
edited
Loading

Fixes #30585.

@dgozman dgozman added the CQ1 label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:389:5 › created › should use different path if attachments base url option is provided

2 flaky ⚠️ [chromium] › components/splitView.spec.tsx:34:5 › should render sidebar first
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

27017 passed, 609 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@dgozman dgozman mentioned this pull request May 21, 2024
Open
@dgozman dgozman added CQ1 and removed CQ1 labels Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests others"

2 fatal errors, not part of any test
26 failed
❌ [chromium-library] › library/browsercontext-events.spec.ts:43:5 › console event should work in popup 2
❌ [chromium-library] › library/browsertype-launch.spec.ts:22:3 › should reject all promises when browser is closed
❌ [chromium-library] › library/chromium/css-coverage.spec.ts:128:3 › should work with a recently loaded stylesheet
❌ [chromium-library] › library/popup.spec.ts:129:3 › should use viewport size from window features
❌ [chromium-library] › library/popup.spec.ts:251:3 › should not throttle rAF in the opener page
❌ [chromium-library] › library/trace-viewer.spec.ts:84:1 › should show empty trace viewer
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
❌ [chromium-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
❌ [chromium-library] › library/tracing.spec.ts:699:5 › should not flush console events
❌ [chromium-library] › library/tracing.spec.ts:742:5 › should flush console events on tracing stop
❌ [chromium-library] › library/video.spec.ts:165:5 › screencast › should work with old options
❌ [chromium-library] › library/video.spec.ts:189:5 › screencast › should capture static page
❌ [chromium-library] › library/video.spec.ts:257:5 › screencast › should delete video
❌ [chromium-library] › library/video.spec.ts:351:5 › screencast › should capture navigation
❌ [chromium-library] › library/video.spec.ts:382:5 › screencast › should capture css transformation
❌ [chromium-library] › library/video.spec.ts:412:5 › screencast › should work for popups
❌ [chromium-library] › library/video.spec.ts:446:5 › screencast › should scale frames down to the requested size
❌ [chromium-library] › library/video.spec.ts:495:5 › screencast › should use viewport scaled down to fit into 800x800 as default size
❌ [chromium-library] › library/video.spec.ts:514:5 › screencast › should be 800x450 by default
❌ [chromium-library] › library/video.spec.ts:531:5 › screencast › should be 800x600 with null viewport
❌ [chromium-library] › library/video.spec.ts:580:5 › screencast › should emulate an iphone
❌ [playwright-test] › reporter-html.spec.ts:296:5 › created › should include image diff when screenshot failed to generate due to animation
❌ [playwright-test] › ui-mode-test-output.spec.ts:157:5 › should stream console messages live
❌ [playwright-test] › ui-mode-test-setup.spec.ts:217:9 › web-mode: true › should run teardown with SIGINT
❌ [webview2] › page/page-request-intercept.spec.ts:178:1 › should intercept multipart/form-data request body

2 flaky ⚠️ [electron-page] › page/page-screenshot.spec.ts:891:3 › should throw if screenshot size is too large
⚠️ [chromium-library] › library/browsercontext-viewport-mobile.spec.ts:177:5 › mobile viewport › should scroll when emulating a mobile viewport

10432 passed, 366 skipped, 2323 did not run
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
12 failed
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/capabilities.spec.ts:112:3 › should support webgl @smoke
❌ [chromium-library] › library/capabilities.spec.ts:120:3 › should support webgl 2 @smoke
❌ [firefox-library] › library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts
❌ [installation tests] › playwright-component-testing.spec.ts:21:5 › pnpm: @playwright/experimental-ct-react should work
❌ [installation tests] › playwright-component-testing.spec.ts:21:5 › pnpm: @playwright/experimental-ct-react should work
❌ [chromium-page] › page/page-leaks.spec.ts:153:5 › waitFor should not leak
❌ [webkit-library] › library/browsercontext-viewport.spec.ts:180:3 › should set window.screen.orientation.type for mobile devices

56 flaky ⚠️ [chromium-library] › library/capabilities.spec.ts:68:3 › should play video @smoke
⚠️ [chromium-page] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:144:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:790:7 › cli codegen › should click button with nested div
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:144:12 › should drag with high dpi
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium-page] › page/matchers.misc.spec.ts:28:3 › should print no-locator-resolved error when locator matcher did not resolve to any element
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:142:3 › should keep selection in multiple pages
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:932:3 › launchServer only › should be able to reconnect to a browser 12 times without warnings
⚠️ [firefox-library] › library/download.spec.ts:529:5 › download event › should be able to cancel pending downloads
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:76:7 › cli codegen › should click after same-document navigation
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:106:7 › cli codegen › should make a positioned click on a canvas
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [firefox-library] › library/trace-viewer.spec.ts:856:1 › should not crash with broken locator
⚠️ [firefox-library] › library/video.spec.ts:257:5 › screencast › should delete video
⚠️ [firefox-page] › page/elementhandle-misc.spec.ts:20:3 › should hover
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-goto.spec.ts:112:3 › should work with Cross-Origin-Opener-Policy after redirect
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-library] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [chromium-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [chromium-library] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:126:5 › mobile viewport › respect meta viewport tag
⚠️ [webkit-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:276:7 › cli codegen › should handle dialogs
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:144:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:483:7 › cli codegen › should check a radio button
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:585:7 › cli codegen › should select with size attribute
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:473:7 › cli codegen › should generate getByLabel
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:562:7 › cli codegen › should assert value
⚠️ [webkit-page] › page/page-drag.spec.ts:35:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:71:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-drag.spec.ts:247:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-page] › page/page-drag.spec.ts:290:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit-library] › library/trace-viewer.spec.ts:179:1 › should show params and return value
⚠️ [webkit-library] › library/screenshot.spec.ts:94:14 › page screenshot › should work with device scale factor and scale:css
⚠️ [webkit-library] › library/screenshot.spec.ts:217:14 › element screenshot › element screenshot should work with device scale factor
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:429:3 › should allow unnamed cookies

202107 passed, 8885 skipped, 1374 did not run
✔️✔️✔️

Merge workflow run.

yury-s
yury-s approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep --use-angle for older Chromium?

@dgozman dgozman merged commit d0b052e into microsoft:main Jun 13, 2024
134 of 176 checks passed
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Jul 12, 2024
@mxschmitt
Revert "fix(chromium): pass --enable-gpu when running headless (micro…
6161877 
…soft#30937)"

This reverts commit d0b052e.
mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Jul 12, 2024
@mxschmitt
Revert "fix(chromium): pass --enable-gpu when running headless (micro…
74ebd79 
…soft#30937)"

This reverts commit d0b052e.
mxschmitt added a commit that referenced this pull request Jul 12, 2024
@mxschmitt
Revert "fix(chromium): pass --enable-gpu when running headless (#30937)"
3127571 
This reverts commit d0b052e.
mxschmitt added a commit that referenced this pull request Jul 12, 2024
@mxschmitt
cherry-pick(#31666): Revert "fix(chromium): pass --enable-gpu when ru…
80f44f3 
…nning headless (#30937)"

This reverts commit d0b052e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: WebGL fails in GitHub Actions on macOS (launcher by Web Test Runner)
2 participants
@dgozman @yury-s