[Feature] disable video creation after context/page creation

[LanderBeeuwsaert]

Let us know what functionality you'd like to see in Playwright and what is your use case.
We use video creation in playwright in our CI environment to easily see what went wrong if a test fails.
so during context creation, we do:

if (this.createVideo) {
  context.recordVideo = { dir: this.storageUploadPath };
}
this.context = await this.browser.newContext(context);

However, we are only interested in the video if the test actually went wrong.
If the test went well, the creation of the video on page/context close only takes (quite a lot) of time away that's not useful.
It would therefor be useful if we could change the setting just before page/context close to say that "nah, don't create a video anyway"

Do you think others might benefit from this as well?
I would think so.

[mxschmitt]

Which test runner are you using? Seems for me that this makes more sense to be implemented in the user land. It wouldn't bring any performance benefit during the test, since it needs to record it anyway and if a test fails, it stops. If you are using playwright-test - playwright official test runner - you would be able to implement such a logic yourself or file an issue that it gets integrated into the project like the screenshotOnFailure functionality.

It's mostly about deleting the video files when the tests are passing if I understood it correctly. A videoOnFailure functionality in the playwright-test project sounds like a great idea.

[LanderBeeuwsaert]

Hi, thanks for the reply,
Well in one project we're using playwright-jest but in the other we're using vanilla playwright (we want more control there to have a pool of contexts running in parallel to speed up the testing --- it gives us a x5 increase ATM).

What we've noticed is the following:

1. during the test, ffmpeg is creating the frames, and this increases the CPU load significantly; but doesn't slow down the test execution. As you say, indeed, this can't be eliminated anyway.

2. After the test, on context close (or page close, I'm not sure) the video file is built from the recorded frames.
   This takes A LOT of time, +- the same amount of time as the test itself, and I suppose a lot of CPU and disk read/writes.
   All this is CPU & Disk load that could be avoided by being able to cancel creation of the video just before we close the context/page.
   => deleting the file after creation would not work as a solution for this.

[mxschmitt]

Yup for 2 I agree there too. (Afaik only Chromium relies on ffmpeg in the end and the others do it somehow else). Could be added improve that behaviour.

Maybe as a spec proposal to be discussed await page.close({ saveVideos: false }) which drops the videos in the end and does not process them.

[LanderBeeuwsaert]

Jep, that would be the best solution.

[pavelfeldman]

(2) seems like a problem in itself, it does not happen on page close, it should be happening in a streaming manner.

[tymfear]

+1 for canceling video creation option

[nmann4]

Another +1. I would also be interested in this feature. I have some long running tests and I've noticed that closing the context/page can take a significant amount of time when video recording is enabled.

[gkushang]

➕ +1 on closing context without processing video-frames. We are seeing very slow executions, and I see it may improve the performance.

[niyarlatotep]

+1