Skip to content

fix(mcp): check tracing state before stopping in browser_stop_tracing #41040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebTardif wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mcp): check tracing state before stopping in browser_stop_tracing #41040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626320f
fix(mcp): check tracing state before stopping in browser_stop_tracing
SebTardif May 29, 2026
82076da
fix: remove invalid saveTrace config property from tracing test
SebTardif Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/tools/backend/tracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ const tracingStop = defineTool({

handle: async (context, params, response) => {
const browserContext = await context.ensureBrowserContext();
await browserContext.tracing.stop();
// eslint-disable-next-line no-restricted-syntax
const traceLegend = (browserContext.tracing as any)[traceLegendSymbol];
if (!traceLegend)
throw new Error('Tracing is not started');
await browserContext.tracing.stop();
// eslint-disable-next-line no-restricted-syntax
delete (browserContext.tracing as any)[traceLegendSymbol];

Expand Down
13 changes: 13 additions & 0 deletions tests/mcp/tracing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,16 @@ test('check that trace is saved with browser_start_tracing (no output dir)', asy
expect.stringMatching(/trace-\d+\.trace/),
]);
});

test('browser_stop_tracing without start returns error', async ({ startClient }) => {
const { client } = await startClient({
args: ['--caps=tracing'],
});

expect(await client.callTool({
name: 'browser_stop_tracing',
})).toHaveResponse({
isError: true,
error: expect.stringContaining('Tracing is not started'),
});
});
Loading