Skip to content

Commit 5999269

Browse files
author
Anastasia Senyushina
authored
Merge pull request #219 from microsoft/v-ankubo/save-error-report
Mark crashReportPath method as public
2 parents 0673cd4 + 211f646 commit 5999269

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# PLCrashReporter Change Log
22

3-
## Version 1.10.1(Under development)
3+
## Version 1.10.1 (Under development)
44

55
* **[Improvement]** Specified minimum cocoapods version in podspec to 1.10.0
6+
* **[Improvement]** Mark `PLCrashReporter.crashReportPath` method as public.
67

78
___
89

Source/PLCrashReporter.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,11 @@ typedef struct PLCrashReporterCallbacks {
142142

143143
- (void) setCrashCallbacks: (PLCrashReporterCallbacks *) callbacks;
144144

145+
/**
146+
* Return the path to live crash report (which may not yet, or ever, exist).
147+
*/
148+
- (NSString *) crashReportPath;
149+
145150
/**
146151
* Custom data to save in the crash report.
147152
*/

Source/PLCrashReporter.m

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,6 @@ - (plcrash_async_symbol_strategy_t) mapToAsyncSymbolicationStrategy: (PLCrashRep
391391
- (BOOL) populateCrashReportDirectoryAndReturnError: (NSError **) outError;
392392
- (NSString *) crashReportDirectory;
393393
- (NSString *) queuedCrashReportDirectory;
394-
- (NSString *) crashReportPath;
395394

396395
@end
397396

@@ -844,6 +843,10 @@ - (void) setCustomData: (NSData *) customData {
844843
plcrash_log_writer_set_custom_data(&signal_handler_context.writer, customData);
845844
}
846845

846+
- (NSString *) crashReportPath {
847+
return [[self crashReportDirectory] stringByAppendingPathComponent: PLCRASH_LIVE_CRASHREPORT];
848+
}
849+
847850
@end
848851

849852
/**
@@ -1061,14 +1064,4 @@ - (NSString *) queuedCrashReportDirectory {
10611064
return [[self crashReportDirectory] stringByAppendingPathComponent: PLCRASH_QUEUED_DIR];
10621065
}
10631066

1064-
1065-
/**
1066-
* Return the path to live crash report (which may not yet, or ever, exist).
1067-
*/
1068-
- (NSString *) crashReportPath {
1069-
return [[self crashReportDirectory] stringByAppendingPathComponent: PLCRASH_LIVE_CRASHREPORT];
1070-
}
1071-
1072-
1073-
10741067
@end

0 commit comments

Comments
 (0)