Fix five app-builder bugs that only surfaced on out-of-the-box tables (#356)

* Fix five app-builder bugs that only surfaced on out-of-the-box tables

Author: akshaymaloo

.github/workflows/model-apps-script-tests.yml

@@ -0,0 +1,90 @@
+# Functional unit tests for the model-apps plugin, across ubuntu × windows × macos
+# and Node 20 × 22.
+#
+# Why a matrix: these scripts shell out to `pac`/`az`, build filesystem paths, and
+# parse CLI output, so path-separator and shell differences are a real regression
+# class that a single-OS run would miss. Both Node versions are covered because the
+# plugin is developed on Node 22 while the repo's other test workflow pins Node 20 —
+# a version-only failure should be attributable, not a mystery.
+#
+# Deliberately mirrors `power-pages-script-tests.yml` rather than extending it: the
+# two plugins have independent path filters, so a change to one must not spend CI
+# time on the other.
+name: model-apps-script-tests
+
+on:
+    pull_request:
+        branches:
+            - main
+        paths:
+            - "plugins/model-apps/**"
+            # The eval harness lives at the repo root but is owned by this plugin, so
+            # an eval-only change must still trigger the eval job below.
+            - "evals/model-apps/**"
+            - ".github/workflows/model-apps-script-tests.yml"
+
+jobs:
+    test-model-apps-scripts:
+        name: test-model-apps-scripts (${{ matrix.os }}, node ${{ matrix.node }})
+        runs-on: ${{ matrix.os }}
+        # Defense-in-depth: opt this CI job out of telemetry transmission so a test
+        # that forgets to isolate emission can never POST to a real collector. The
+        # plugin's committed ikey.json currently ships `disabled: true`, but that is
+        # a value that can change; the guard must not depend on it. Suppresses
+        # TRANSMISSION only — the local diagnostic mirror is still written, so this
+        # cannot change what the tests actually assert.
+        env:
+            POWER_PLATFORM_SKILLS_TELEMETRY_MODEL_APPS_OPTOUT: "1"
+        strategy:
+            fail-fast: false
+            matrix:
+                os:
+                    - ubuntu-latest
+                    - windows-latest
+                    - macos-latest
+                node:
+                    - 20
+                    - 22
+        steps:
+            - name: checkout
+              uses: actions/checkout@v4
+
+            - name: setup-node
+              uses: actions/setup-node@v4
+              with:
+                  node-version: ${{ matrix.node }}
+
+            # run-tests.js is the plugin's own regression gate: it runs every
+            # scripts/tests/*.test.js and exits non-zero on any failure. Invoking it
+            # (rather than a bare `node --test`) keeps CI and the documented local
+            # command identical, so a green PR means the same thing a green local run
+            # does. The vendored SDK's own Jest suite is intentionally NOT run here —
+            # it needs a Node-20-ABI `canvas` native module and the SDK source tree,
+            # neither of which exists in this repo; the real-bundle contract tests in
+            # scripts/tests/ cover the shipped bundle instead.
+            - name: run-model-apps-script-tests
+              shell: bash
+              working-directory: plugins/model-apps
+              run: node scripts/run-tests.js
+
+    test-model-apps-evals:
+        name: test-model-apps-evals
+        runs-on: ubuntu-latest
+        env:
+            POWER_PLATFORM_SKILLS_TELEMETRY_MODEL_APPS_OPTOUT: "1"
+        steps:
+            - name: checkout
+              uses: actions/checkout@v4
+
+            - name: setup-node
+              uses: actions/setup-node@v4
+              with:
+                  node-version: 20
+
+            # The eval harness lives at the repo root (evals/model-apps/**) but is
+            # owned by this plugin, so it is gated by the same path filter. These are
+            # the offline scoring/fixture tests only — the Layer 1/2 runners need a
+            # live Dataverse org and are run manually.
+            - name: run-model-apps-eval-tests
+              shell: bash
+              run: node --test evals/model-apps/app-builder/tests/*.test.js evals/model-apps/genpage/tests/*.test.js

AGENTS.md

@@ -41,6 +41,25 @@ claude --plugin-dir /path/to/plugins/<plugin-name>
 
 No root-level build, lint, or test commands exist. Build/test tooling lives inside each plugin.
 
+## CI
+
+**Only two workflows run on every PR** — `validate-keyword-case` and `validate-repository-metadata`.
+Both are repo-wide and enforce metadata/marketplace rules, not behavior.
+
+**Every test workflow is path-filtered to a single plugin** (`power-pages` → `plugins/power-pages/**`;
+`model-apps` → `plugins/model-apps/**` + `evals/model-apps/**`). This is deliberate — a PR should not
+spend CI on a plugin it never touched — but it has a corollary: *a green PR does not mean the repo is
+green*, only that the paths you touched are.
+
+**A test suite with no workflow silently never runs.** When you add tests to a plugin, add or extend
+that plugin's own path-filtered workflow in the same PR; do not widen another plugin's filter to
+cover yours.
+
+A plugin that has adopted telemetry must also set its opt-out env var on any job that could execute a
+telemetry-emitting hook or script (see `## Shared Telemetry`) — e.g.
+`POWER_PLATFORM_SKILLS_TELEMETRY_MODEL_APPS_OPTOUT: "1"`. It suppresses transmission only, so it
+cannot change what a test asserts.
+
 ## Plugin Conventions
 
 Each plugin follows this structure:

plugins/model-apps/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "model-apps",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "Build model-driven Power Apps end to end: /app-builder authors whole apps (tables, relationships, forms, views, charts, security roles, app + sitemap) from a natural-language intent, and /genpage builds generative pages with specialist agents for planning, entity creation, and parallel code generation. Requires PAC CLI >= 2.7.0 and Azure CLI (`az`). See CHANGELOG.md for v1.x -> v2.x migration.",
   "author": {
     "name": "Microsoft",

plugins/model-apps/.plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "model-apps",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "Build model-driven Power Apps end to end: /app-builder authors whole apps (tables, relationships, forms, views, charts, security roles, app + sitemap) from a natural-language intent, and /genpage builds generative pages with specialist agents for planning, entity creation, and parallel code generation. Requires PAC CLI >= 2.7.0 and Azure CLI (`az`). See CHANGELOG.md for v1.x -> v2.x migration.",
   "author": {
     "name": "Microsoft",