Accept nullable SourceType for ordinary columns

Treat Dataverse null SourceType as valid for ordinary Memo and Lookup metadata while retaining fail-closed validation for specialized columns.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 78870709-25fe-45d7-8669-dd0ba9470807

Author: Shubham Agarwal

plugins/mobile-apps/scripts/build-dataverse-operation-manifest.js

@@ -50,6 +50,11 @@ const DERIVED_COLUMN_TYPES = new Set([
   'lookup',
   'computed',
 ]);
+const NULL_SOURCE_TYPE_IS_ORDINARY_TYPES = new Set([
+  'lookup',
+  'memo',
+  'multiline',
+]);
 
 function parseArgs(argv) {
   const args = {};
@@ -1110,9 +1115,13 @@ function baseColumnCompatibility(column, liveColumn) {
       );
     }
   }
-  if (!hasOwn(liveColumn, 'sourceType') || liveColumn.sourceType === null) {
+  const normalizedColumnType = normalizeColumnType(column.type);
+  if (!hasOwn(liveColumn, 'sourceType')) {
+    reasons.push('SourceType evidence is missing');
+  } else if (liveColumn.sourceType === null
+    && !NULL_SOURCE_TYPE_IS_ORDINARY_TYPES.has(normalizedColumnType)) {
     reasons.push('SourceType evidence is missing');
-  } else if (!DERIVED_COLUMN_TYPES.has(normalizeColumnType(column.type))
+  } else if (!DERIVED_COLUMN_TYPES.has(normalizedColumnType)
     && Number(liveColumn.sourceType) !== 0) {
     reasons.push(`ordinary column has SourceType ${liveColumn.sourceType}`);
   }

plugins/mobile-apps/scripts/tests/dataverse-operation-manifest.test.js

@@ -1287,6 +1287,64 @@ test('ordinary-column reuse requires complete compatible behavior evidence', ()
   }
 });
 
+test('ordinary Memo and Lookup columns accept nullable Dataverse SourceType', () => {
+  const lookupReconciliation = fullyAppliedSnapshot();
+  lookupReconciliation.tables
+    .find((tableValue) => tableValue.logicalName === 'cr1_item')
+    .columns
+    .find((columnValue) => columnValue.logicalName === 'cr1_categoryid')
+    .sourceType = null;
+  const lookupManifest = buildManifest(buildInputs(
+    createContract(),
+    lookupReconciliation,
+  ));
+  assert.equal(lookupManifest.executable, true);
+  assert.equal(lookupManifest.summary.metadataOperationCount, 0);
+
+  const memoContract = {
+    schemaVersion: 1,
+    publisherPrefix: 'cr1',
+    tables: [
+      contractTable('cr1_note', 'extend', 0, [
+        contractColumn('cr1_name', 'string', 'reuse', { primaryName: true }),
+        contractColumn('cr1_description', 'memo', 'reuse', {
+          maxLength: 10000,
+          format: 'TextArea',
+        }),
+      ]),
+    ],
+  };
+  const memoManifest = buildManifest(buildInputs(memoContract, snapshot({
+    tables: [table('cr1_note', [
+      column('cr1_name', 'String', { primaryName: true }),
+      column('cr1_description', 'Memo', { sourceType: null }),
+    ])],
+  })));
+  assert.equal(memoManifest.executable, true);
+  assert.equal(memoManifest.summary.metadataOperationCount, 0);
+
+  const stringWithNullSourceType = column('cr1_name', 'String', {
+    primaryName: true,
+    sourceType: null,
+  });
+  const blocked = buildManifest(buildInputs({
+    schemaVersion: 1,
+    publisherPrefix: 'cr1',
+    tables: [
+      contractTable('cr1_note', 'extend', 0, [
+        contractColumn('cr1_name', 'string', 'reuse', { primaryName: true }),
+      ]),
+    ],
+  }, snapshot({
+    tables: [table('cr1_note', [stringWithNullSourceType])],
+  })));
+  assert.equal(blocked.executable, false);
+  assert.match(
+    blocked.decisions.find((item) => item.itemType === 'column').reason,
+    /SourceType evidence is missing/,
+  );
+});
+
 test('ordinary-column precision, range, date behavior, and primary-name constraints are enforced', () => {
   const contract = {
     schemaVersion: 1,