Skip to content

Commit c4befeb

Browse files
akshay-vizCopilot
andcommitted
docs(model-apps): repair two comment tokens mangled by a shell escape
Caught by an adversarial production-readiness review. The pagination test's comment was written through a PowerShell here-string, and PowerShell consumed the backticks as escape characters: ` `top: 5000` ` became a literal TAB, and ` `\\` ` was swallowed entirely, leaving "Dataverse honors as a hard cap". The comment explains WHY the query must not combine paginate with top, which is the whole point of the test, so a reader hitting the corrupted line loses the reason and may "simplify" the query back. Comment text only; no behaviour change. Swept the other four test files appended the same way -- no further corruption. 1522 tests still pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 42626da2-b66f-4162-acaa-b1127ef23d89
1 parent 5b79b95 commit c4befeb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

plugins/model-apps/scripts/tests/verify-model-app.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,11 @@ test('entityPrivileges is ABSENT (not broken) when the client or org url is miss
484484
});
485485

486486
test('rolePrivileges paginates and never caps with top', async () => {
487-
// Found by a LIVE run: with the previous op: 5000 a System Administrator role returned
487+
// Found by a LIVE run: with the previous `top: 5000` a System Administrator role returned
488488
// EXACTLY 5000 rows -- silently truncated. Paginated it returns 7119, so 2119 privileges were
489489
// being dropped. A truncated page is the worst shape for this check: a declared privilege that
490490
// fell off the end reads as NOT HELD, so verify reports a correctly configured role as missing.
491-
// Dataverse honors as a hard cap and omits @odata.nextLink, and the SDK rejects
491+
// Dataverse honors `$top` as a hard cap and omits @odata.nextLink, and the SDK rejects
492492
// paginate+top, so asserting the ABSENCE of top matters as much as the presence of paginate.
493493
const calls = [];
494494
const sdk = stubSdk();

0 commit comments

Comments
 (0)