Commit cb567d7
chore(model-apps): remove real environment identifiers from a public repo
The genpage eval fixtures are captured agent transcripts, so they recorded
whatever live environment each eval ran against — including `pac auth list`
output carrying the operator's UPN, tenant, and environment URL. That had
accumulated to 98 occurrences of three environments, two tenants and two user
accounts across 28 files, plus provenance comments in four scripts and the
roadmap.
Fixture replacements are equal-length. The fixtures embed `pac auth list`
output as a fixed-width table, so a shorter placeholder would misalign every
following column and make a captured artifact look hand-edited. Verified: the
diff is exactly 65 insertions / 65 deletions with no line-ending drift (the
fixtures are LF, the scripts CRLF).
Script provenance comments are generalised rather than substituted. "Verified
live on <envname>" carries a real claim; swapping in a fake environment name
would keep the sentence readable but make it false, so the claim is kept and
the environment dropped ("verified live on a Dataverse test environment").
Adds `scripts/validate-no-real-environments.js` so the scrub sticks. Pasting a
fresh live transcript is the realistic regression path and it looks correct to
a reviewer. The guard matches on shape, not just on the strings removed here:
`org<8 hex>` is what Dataverse auto-generates, so it is rejected even though it
starts with the otherwise-allowed word `org`. Scoped to model-apps, because
other plugins still carry pre-existing references of this class and widening
the scan today would fail unrelated PRs; the limitation is documented in the
script header and in AGENTS.md rather than left implicit.
No behaviour change: 1474 plugin tests, 159 eval tests, and 12/12 layer-1
fixtures still pass. The layer-1 assertions match generic URL shapes
(`/https?:\/\/[a-z0-9-]+\.(crm|dynamics)/i`), not any specific environment, so
the rewritten fixtures still exercise them.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 42626da2-b66f-4162-acaa-b1127ef23d891 parent d2ec894 commit cb567d7
34 files changed
Lines changed: 394 additions & 65 deletions
File tree
- .github/workflows
- evals/model-apps/genpage/fixtures
- 1-account-card-gallery
- 11-recruitment-multi-page
- 11-recruitment-pages-real
- 13-contact-localization
- 15-support-tickets-real
- 2-mock-dashboard-real
- 2-mock-dashboard
- 4-case-wizard
- 5-kanban-task-board
- 7-job-candidates-new-entities
- plugins/model-apps
- docs
- scripts
- lib
- tests
- scripts
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
40 | 55 | | |
41 | 56 | | |
42 | 57 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
0 commit comments