Fix Windows browser opener

Pass the browser target through an environment variable instead of as a positional PowerShell argument after -Command. This prevents Windows PowerShell from rejecting status-page URLs as extra command tokens.

Copilot-Session: a9952624-0a25-4d6e-ae67-537c962a8a60

Author: priyanshu92

plugins/power-pages/scripts/lib/default-browser.js

@@ -10,9 +10,16 @@ function openInDefaultBrowser(target, deps = {}) {
     execFile('open', [target], { stdio: 'ignore' });
   } else if (platform === 'win32') {
     // Avoid `cmd /c start`: cmd.exe reparses metacharacters such as `&` in URL
-    // query strings. Passing the target as a PowerShell argument keeps it as
-    // data while still letting Windows choose the registered default handler.
-    execFile('powershell.exe', ['-NoProfile', '-Command', 'param([string]$Target) Start-Process -FilePath $Target', target], { stdio: 'ignore', windowsHide: true });
+    // query strings. Also avoid passing the URL as a positional PowerShell
+    // argument after `-Command`; Windows PowerShell can treat it as an extra
+    // command token instead of binding it to `param(...)`. An environment
+    // variable keeps URLs and file paths as inert data while Start-Process still
+    // uses the registered default handler.
+    execFile('powershell.exe', ['-NoProfile', '-Command', 'Start-Process -FilePath $env:COPILOT_OPEN_TARGET'], {
+      stdio: 'ignore',
+      windowsHide: true,
+      env: { ...process.env, COPILOT_OPEN_TARGET: target },
+    });
   } else {
     execFile('xdg-open', [target], { stdio: 'ignore' });
   }

plugins/power-pages/scripts/tests/open-url.test.js

@@ -14,11 +14,13 @@ test('openInDefaultBrowser uses platform-specific opener commands', () => {
   openInDefaultBrowser('https://example.test/a path?q=1&x=2', { os: { platform: () => 'win32' }, execFileSync });
   openInDefaultBrowser('https://example.test', { os: { platform: () => 'linux' }, execFileSync });
 
-  assert.deepEqual(calls, [
-    ['open', ['https://example.test'], { stdio: 'ignore' }],
-    ['powershell.exe', ['-NoProfile', '-Command', 'param([string]$Target) Start-Process -FilePath $Target', 'https://example.test/a path?q=1&x=2'], { stdio: 'ignore', windowsHide: true }],
-    ['xdg-open', ['https://example.test'], { stdio: 'ignore' }],
-  ]);
+  assert.deepEqual(calls[0], ['open', ['https://example.test'], { stdio: 'ignore' }]);
+  assert.equal(calls[1][0], 'powershell.exe');
+  assert.deepEqual(calls[1][1], ['-NoProfile', '-Command', 'Start-Process -FilePath $env:COPILOT_OPEN_TARGET']);
+  assert.equal(calls[1][2].stdio, 'ignore');
+  assert.equal(calls[1][2].windowsHide, true);
+  assert.equal(calls[1][2].env.COPILOT_OPEN_TARGET, 'https://example.test/a path?q=1&x=2');
+  assert.deepEqual(calls[2], ['xdg-open', ['https://example.test'], { stdio: 'ignore' }]);
 });
 
 test('openUrl validates URL shape and reports opener failures without throwing', () => {