added tooltip bucket (#103)

Author: mvgaliev

CHANGELOG.md

@@ -1,7 +1,7 @@
 ## 1.9.4
  * Fixed issue with tooltip duration
  * Fixed issue with invisible task line when duration is 1
- * Added ability to use custom tooltip rows
+ * Renamed "Extra imformation" field bucket to "Tooltips"
 ## 1.9.3
  * Fixed issue with tooltip duration
  * Fixed issue with line length with float value and 'second' duration

capabilities.json

@@ -60,15 +60,9 @@
         },
         {
             "name": "ExtraInformation",
-            "displayName": "Extra information",
-            "displayNameKey": "Role_ExtraInformation",
-            "kind": "Grouping"
-        },
-        {
-            "name": "Tooltips",
             "displayName": "Tooltips",
             "displayNameKey": "Role_Tooltips",
-            "kind": "Measure"
+            "kind": "Grouping"
         }
     ],
     "dataViewMappings": [
@@ -204,11 +198,6 @@
                             "for": {
                                 "in": "ExtraInformation"
                             }
-                        },
-                        {
-                            "for": {
-                                "in": "Tooltips"
-                            }
                         }
                     ]
                 },
@@ -225,11 +214,6 @@
                                 "for": {
                                     "in": "Completion"
                                 }
-                            },
-                            {
-                                "for": {
-                                    "in": "Tooltips"
-                                }
                             }
                         ]
                     }

src/columns.ts

@@ -55,12 +55,7 @@ module powerbi.extensibility.visual {
                              columns = {};
                          }
                          columns[x.source.displayName] = x.values;
-                     } else if (x.source.roles && x.source.roles["Tooltips"]) {
-                        if (!columns) {
-                            columns = {};
-                        }
-                        columns[x.source.displayName] = x.values;
-                    } else {
+                     } else {
                          columns = x.values;
                      }
                   });
@@ -83,6 +78,5 @@ module powerbi.extensibility.visual {
         public Completion: T = null;
         public Resource: T = null;
         public ExtraInformation: T = null;
-        public Tooltips: T = null;
     }
 }

src/gantt.ts

@@ -740,7 +740,6 @@ module powerbi.extensibility.visual {
                 let taskType: TaskTypeMetadata = null;
                 let wasDowngradeDurationUnit: boolean = false;
                 let tooltips: VisualTooltipDataItem[] = [];
-                let skipTooltipNames: string[] = [];
                 let stepDurationTransformation: number = 0;
 
                 const selectionBuider: ISelectionIdBuilder = host
@@ -782,14 +781,6 @@ module powerbi.extensibility.visual {
                                     completion = Gantt.ComplectionMax;
                                 }
                             }
-
-                            if (group.Tooltips && group.Tooltips.values[index]) {
-                                tooltips.push({
-                                    displayName: group.Tooltips.source.displayName,
-                                    value: group.Tooltips.values[index]
-                                } as VisualTooltipDataItem);
-                                skipTooltipNames.push(group.Tooltips.source.displayName);
-                            }
                         }
                     });
                 }
@@ -815,17 +806,6 @@ module powerbi.extensibility.visual {
                     }
                 }
 
-                if (values.Tooltips) {
-                    const extraTooltipKeys: any[] = Object.keys(values.Tooltips);
-                    for (const key of extraTooltipKeys.filter(k => skipTooltipNames.indexOf(k) < 0)) {
-                        const value: string = values.Tooltips[key][index];
-                        tooltips.push({
-                            displayName: key,
-                            value: value || ""
-                        });
-                    }
-                }
-
                 const task: Task = {
                     color,
                     completion,

stringResources/en-US/resources.resjson

@@ -5,7 +5,6 @@
 	"Role_Duration": "Duration",
 	"Role_Completion": "% Completion",
 	"Role_Resource": "Resource",
-  	"Role_ExtraInformation": "Extra information",
 	"Role_Tooltips": "Tooltips",
 	"Visual_General": "General",
 	"Visual_GroupTasks": "Group Tasks",

test/visualData.ts

@@ -43,7 +43,6 @@ module powerbi.extensibility.visual.test {
         public static ColumnCompletePrecntege: string = "CompletePrecntege";
         public static ColumnExtraInformation: string = "Description";
         public static ColumnParent: string = "Parent";
-        public static ColumnTooltips: string = "Tooltips";
 
         public valuesTaskTypeResource: string[][] = [
             ["Spec", "MOLAP connectivity", "Mey"],
@@ -83,7 +82,6 @@ module powerbi.extensibility.visual.test {
         public valuesDuration = GanttData.getRandomUniqueNumbers(this.valuesTaskTypeResource.length, 3, 40);
         public valuesCompletePrecntege = GanttData.getRandomUniqueNumbers(this.valuesTaskTypeResource.length);
         public valuesExtraInformation = GanttData.getTexts(this.valuesTaskTypeResource, "Description");
-        public valuesTooltips = GanttData.getTexts(this.valuesTaskTypeResource, "Description");
 
         public static getTexts(valuesTaskTypeResource: string[][], text: string): string[] {
             return valuesTaskTypeResource.map((item) => {