Skip to content

Commit 0b49b50

Browse files
mvgalievignatvilesov
authored andcommitted
Fixed IE issue (#13)
1 parent d1e3d31 commit 0b49b50

4 files changed

Lines changed: 13 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 1.1.1
2+
* Fixed blank window issue in Internet Explorer
3+
14
## 1.1.0
25
* Add Dot opacity property
36
* Add axes color property

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "powerbi-visuals-linedotchart",
33
"description": "LineDot Chart",
4-
"version": "1.1.0",
4+
"version": "1.1.1",
55
"author": {
66
"name": "Microsoft",
77
"email": "pbicvsupport@microsoft.com"
@@ -24,13 +24,14 @@
2424
"@types/d3": "3.5.36",
2525
"@types/jasmine": "2.5.47",
2626
"@types/jasmine-jquery": "1.5.30",
27-
"@types/jquery": "2.0.46",
27+
"@types/jquery": "2.0.41",
2828
"@types/lodash": "4.14.55",
2929
"coveralls": "2.13.1",
3030
"d3": "3.5.5",
3131
"globalize": "0.1.0-a2",
3232
"jasmine": "2.5.2",
3333
"jasmine-jquery": "2.1.1",
34+
"jquery": "3.1.1",
3435
"karma": "1.3.0",
3536
"karma-chrome-launcher": "2.0.0",
3637
"karma-coverage": "1.1.1",

src/settings.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module powerbi.extensibility.visual {
2828
import DataViewObjectsParser = powerbi.extensibility.utils.dataview.DataViewObjectsParser;
2929

3030
export class LineDotChartSettings extends DataViewObjectsParser {
31-
public isCounterDateTime: boolean = false;
31+
public isCounterDateTime: CounterDateTime = new CounterDateTime();
3232
public axisOptions: AxisSettings = new AxisSettings();
3333
public lineoptions: LineSettings = new LineSettings();
3434
public dotoptions: DotSettings = new DotSettings();
@@ -63,4 +63,8 @@ module powerbi.extensibility.visual {
6363
public isStopped: boolean = true;
6464
public duration: number = 20;
6565
}
66+
67+
export class CounterDateTime {
68+
public isCounterDateTime: boolean = true;
69+
}
6670
}

src/visual.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ module powerbi.extensibility.visual {
277277

278278
if (counterValues && counterValues.length > 0) {
279279
let fValue: any = counterValues[0];
280-
settings.isCounterDateTime = fValue.getDate ? true : false;
280+
settings.isCounterDateTime.isCounterDateTime = fValue.getDate ? true : false;
281281
}
282282

283283
const dateValues: DateValue[] = [],
@@ -705,7 +705,7 @@ module powerbi.extensibility.visual {
705705
.each("start", (d: LineDotPoint, i: number) => {
706706
let text = this.settings.counteroptions.counterTitle + ' ';
707707
if (d.counter) {
708-
text += this.settings.isCounterDateTime ? this.data.dateColumnFormatter.format(d.counter) : d.counter;
708+
text += this.settings.isCounterDateTime.isCounterDateTime ? this.data.dateColumnFormatter.format(d.counter) : d.counter;
709709
} else {
710710
text += (i + 1);
711711
}

0 commit comments

Comments
 (0)