Skip to content

Commit 0a3db5a

Browse files
authored
Block sending requests if the deployment key is missed (#1967)
1 parent c0cc20e commit 0a3db5a

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CodePush.js

+4
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,10 @@ async function tryReportStatus(statusReport, resumeListener) {
188188
if (statusReport.appVersion) {
189189
log(`Reporting binary update (${statusReport.appVersion})`);
190190

191+
if (!config.deploymentKey) {
192+
throw new Error("Deployment key is missed");
193+
}
194+
191195
const sdk = getPromisifiedSdk(requestFetchAdapter, config);
192196
await sdk.reportStatusDeploy(/* deployedPackage */ null, /* status */ null, previousLabelOrAppVersion, previousDeploymentKey);
193197
} else {

code-push-plugin-testing-framework/script/testUtil.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var TestUtil = (function () {
4545
options = options || {};
4646
// set default options
4747
if (options.maxBuffer === undefined)
48-
options.maxBuffer = 1024 * 500;
48+
options.maxBuffer = 1024 * 1024 * 500;
4949
if (options.timeout === undefined)
5050
options.timeout = 10 * 60 * 1000;
5151
if (!options.noLogCommand)

test/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ class RNIOS extends Platform.IOS implements RNPlatform {
233233
const hashWithParen = targetEmulator.match(hashRegEx)[0];
234234
const hash = hashWithParen.substr(1, hashWithParen.length - 2);
235235
return TestUtil.getProcessOutput("xcodebuild -workspace " + path.join(iOSProject, TestConfig.TestAppName) + ".xcworkspace -scheme " + TestConfig.TestAppName +
236-
" -configuration Release -destination \"platform=iOS Simulator,id=" + hash + "\" -derivedDataPath build", { cwd: iOSProject, maxBuffer: 1024 * 1024 * 20, noLogStdOut: true });
236+
" -configuration Release -destination \"platform=iOS Simulator,id=" + hash + "\" -derivedDataPath build EXCLUDED_ARCHS=arm64", { cwd: iOSProject, maxBuffer: 1024 * 1024 * 500, noLogStdOut: true });
237237
})
238238
.then<void>(
239239
() => { return null; },

0 commit comments

Comments
 (0)