Skip to content

Commit 4eee96f

Browse files
author
Max
authored
fixed Failing signature check on iOS 9.3, working on iOS 10.3 #1021 issue (#1027)
1 parent b14654e commit 4eee96f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

ios/CodePush/JWT/Core/Algorithms/RSFamily/RSKeys/JWTCryptoKey.m

+4-1
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,13 @@ @interface JWTCryptoKey (ParametersExtraction)
6161
- (NSString *)extractedSecKeyTypeWithParameters:(NSDictionary *)parameters;
6262
- (JWTCryptoKeyBuilder *)extractedBuilderWithParameters:(NSDictionary *)parameters;
6363
@end
64+
// Consider that both methods in this category should return non-nullable values
6465
@implementation JWTCryptoKey (ParametersExtraction)
66+
// Parameters are nil at that moment, could be used later for some purposes
6567
- (JWTCryptoKeyBuilder *)extractedBuilderWithParameters:(NSDictionary *)parameters {
66-
return (JWTCryptoKeyBuilder *)parameters[[self.class parametersKeyBuilder]];
68+
return (JWTCryptoKeyBuilder *)parameters[[self.class parametersKeyBuilder]] ?: [JWTCryptoKeyBuilder new].keyTypeRSA;
6769
}
70+
// Parameters are nil at that moment, could be used later for some purposes
6871
- (NSString *)extractedSecKeyTypeWithParameters:(NSDictionary *)parameters {
6972
JWTCryptoKeyBuilder *builder = [self extractedBuilderWithParameters:parameters];
7073
NSString *result = nil;

0 commit comments

Comments
 (0)