Merge pull request #94 from oney/fix-semver-compare

lostintangent · lostintangent · commit 5b6fbdbf3280 · 2015-12-06T13:23:36.000-08:00
Fix semver compare when first version
diff --git a/CodePush.js b/CodePush.js
@@ -50,7 +50,7 @@ function checkForUpdate(deploymentKey = null) {
              * to send the app version to the server, since we are interested
              * in any updates for current app store version, regardless of hash.
              */
-            if (localPackage && semver.compare(localPackage.appVersion, config.appVersion) === 0) {
+            if (localPackage && localPackage.appVersion && semver.compare(localPackage.appVersion, config.appVersion) === 0) {
               queryPackage = localPackage;
             }
             

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ function checkForUpdate(deploymentKey = null) {`
`50`	`50`	`* to send the app version to the server, since we are interested`
`51`	`51`	`* in any updates for current app store version, regardless of hash.`
`52`	`52`	`*/`
`53`		`- if (localPackage && semver.compare(localPackage.appVersion, config.appVersion) === 0) {`
	`53`	`+ if (localPackage && localPackage.appVersion && semver.compare(localPackage.appVersion, config.appVersion) === 0) {`
`54`	`54`	`queryPackage = localPackage;`
`55`	`55`	`}`
`56`	`56`