Skip to content

Commit d25489c

Browse files
committed
Merge pull request #78 from Microsoft/delete-old-package-error
Prevent error in deleting old packages from failing the install operation.
2 parents eeb4901 + 1a7a955 commit d25489c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

CodePushPackage.m

+5-3
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,11 @@ + (void)installPackage:(NSDictionary *)updatePackage
221221
NSString *previousPackageHash = [self getPreviousPackageHash:error];
222222
if (!*error && previousPackageHash && ![previousPackageHash isEqualToString:packageHash]) {
223223
NSString *previousPackageFolderPath = [self getPackageFolderPath:previousPackageHash];
224-
[[NSFileManager defaultManager] removeItemAtPath:previousPackageFolderPath error:error];
225-
if (*error) {
226-
return;
224+
// Error in deleting old package will not cause the entire operation to fail.
225+
NSError *deleteError;
226+
[[NSFileManager defaultManager] removeItemAtPath:previousPackageFolderPath error:&deleteError];
227+
if (deleteError) {
228+
NSLog(@"Error deleting old package: %@", deleteError);
227229
}
228230
}
229231

0 commit comments

Comments
 (0)