Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Manager should use contexts #317

Open
timraymond opened this issue Apr 25, 2024 · 0 comments
Open

Capture Manager should use contexts #317

timraymond opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers lang/go The Go Programming Language priority/2 P2 scope/M Change is Medium type/enhancement New feature or request

Comments

@timraymond
Copy link
Member

CaptureManager is often responsible for interacting with multiple APIs, including the k8s apiserver. It's apparent from PRs that add new functionality to CaptureManager that there is many context.TODO()s in places where these interactions take place (see: https://github.com/microsoft/retina/pull/295/files#diff-99babd138c7f336f6abec8bd499b3593610bad046a34d47e8d448a7600040c7bR104) . This could be added with a bit of work, binding to the os.Signal channel. While this might ultimately yield the same result, it at least establishes a context heirarchy that will be more easily iterated on in the future.

@rbtr rbtr self-assigned this Apr 25, 2024
@rbtr rbtr added type/enhancement New feature or request good first issue Good for newcomers lang/go The Go Programming Language priority/2 P2 scope/M Change is Medium labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers lang/go The Go Programming Language priority/2 P2 scope/M Change is Medium type/enhancement New feature or request
Projects
Status: Accepted
Development

No branches or pull requests

2 participants