refactor: read min Node version from root workspace (#3618)

Author: tido64

.changeset/twenty-apricots-turn.md

@@ -0,0 +1,2 @@
+---
+---

scripts/new-package.ts

@@ -5,6 +5,7 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { URL, fileURLToPath } from "node:url";
 import { parseArgs } from "node:util";
+import { getRootEnginesField } from "./src/rootWorkspace.js";
 
 type Options = {
   experimental?: boolean;
@@ -16,15 +17,6 @@ const USAGE_TOKEN_START = "<!-- usage start -->";
 const USAGE_TOKEN_END = "<!-- usage end -->";
 const WARNING_BANNER_TOKEN = "<!-- experimental-warning -->";
 
-function getRootEnginesField(): Record<string, string> {
-  const root = fs.readFileSync(new URL("../package.json", import.meta.url));
-  const manifest = JSON.parse(root.toString());
-  if (typeof manifest.engines !== "object") {
-    throw new Error("'engines' field is incorrectly configured");
-  }
-  return manifest.engines;
-}
-
 function writeTextFile(destination: string, data: unknown): void {
   const fd = fs.openSync(destination, "w");
   if (typeof data === "string") {

scripts/src/commands/bundle.js

@@ -3,6 +3,7 @@
 import { getDynamicLibs } from "@yarnpkg/cli";
 import { Command, Option } from "clipanion";
 import * as fs from "node:fs";
+import { getRootEnginesField } from "../rootWorkspace.js";
 
 /**
  * @typedef {import("esbuild").BuildOptions} BuildOptions
@@ -50,16 +51,35 @@ export class BundleCommand extends Command {
   });
 
   async execute() {
-    await bundle({
+    const { name, outfile } = await bundle({
       minify: this.minify,
       platform: this.platform,
       sourceMap: this.sourceMap,
     });
+
+    // report success with file size of the output file
+    if (!process.stdin.isTTY && fs.existsSync(outfile)) {
+      const sizeKb = Math.round(fs.statSync(outfile).size / 1024);
+      this.context.stdout.write(`Success: ${name} bundled: ${sizeKb}kb\n`);
+    }
   }
 }
 
 const defaultTarget = "es2021";
-const defaultNodeTarget = "node16.17";
+
+/**
+ * @param {Manifest} manifest
+ * @returns {string}
+ */
+function getNodeTarget(manifest) {
+  const enginesNode = manifest.engines?.node ?? getRootEnginesField().node;
+  const match = enginesNode?.match(/(\d+)\.(\d+)/);
+  if (!match) {
+    throw new Error("Could not get minimum Node version");
+  }
+
+  return `node${match[1]}.${match[2]}`;
+}
 
 /**
  * @param {Manifest} manifest
@@ -173,38 +193,26 @@ function platformOptions(platform, manifest) {
   return preset(manifest);
 }
 
-/**
- * @param {Manifest} manifest
- * @returns {string}
- */
-function getNodeTarget(manifest) {
-  const enginesNode = manifest.engines?.node;
-  const match = enginesNode?.match(/(\d+)\.(\d+)/);
-  return match ? `node${match[1]}.${match[2]}` : defaultNodeTarget;
-}
-
 /**
  * @param {Record<string, unknown> | undefined} options
+ * @returns {Promise<{ name: string; outfile: string; }>}
  */
 export async function bundle(options) {
   const { minify, platform, sourceMap } = options || {};
 
   const manifestFile = fs.readFileSync("package.json", { encoding: "utf-8" });
   const manifest = JSON.parse(manifestFile);
+  const { name, main: outfile } = manifest;
 
   const esbuild = await import("esbuild");
   await esbuild.build({
     ...platformOptions(platform, manifest),
     bundle: true,
-    outfile: manifest.main,
+    outfile,
     entryPoints: ["src/index.ts"],
     minify: Boolean(minify),
     sourcemap: Boolean(sourceMap),
   });
 
-  // report success with file size of the output file
-  if (fs.existsSync(manifest.main)) {
-    const sizeKb = Math.round(fs.statSync(manifest.main).size / 1024);
-    console.log(`Success: ${manifest.name} bundled: ${sizeKb}kb`);
-  }
+  return { name, outfile };
 }

scripts/src/rootWorkspace.js

@@ -0,0 +1,16 @@
+// @ts-check
+import * as fs from "node:fs";
+import { URL } from "node:url";
+
+/**
+ * @returns {Record<string, string>}
+ */
+export function getRootEnginesField() {
+  const root = fs.readFileSync(new URL("../../package.json", import.meta.url));
+  const manifest = JSON.parse(root.toString());
+  if (typeof manifest.engines !== "object") {
+    throw new Error("'engines' field is incorrectly configured");
+  }
+
+  return manifest.engines;
+}