Cleanup

Author: JoseRenan

test/Microsoft.Sbom.Api.Tests/Output/Telemetry/TelemetryRecorderTests.cs

@@ -99,14 +99,11 @@ public void TelemetryRecorder_Exceptions_Property_ReturnsRecordedExceptions()
         var testException1 = new InvalidOperationException("Test exception 1");
         var testException2 = new ArgumentException("Test exception 2");
 
-        // Initially, no exceptions should be recorded
         Assert.AreEqual(0, telemetryRecorder.Exceptions.Count);
 
-        // Record some exceptions
         telemetryRecorder.RecordException(testException1);
         telemetryRecorder.RecordException(testException2);
 
-        // Verify exceptions are accessible through the property
         Assert.AreEqual(2, telemetryRecorder.Exceptions.Count);
         Assert.IsTrue(telemetryRecorder.Exceptions.Contains(testException1));
         Assert.IsTrue(telemetryRecorder.Exceptions.Contains(testException2));

test/Microsoft.Sbom.Api.Tests/SbomValidatorTests.cs

@@ -57,7 +57,6 @@ public void AfterEachTest()
     [TestMethod]
     public async Task ValidateSbomAsync_WithNoErrorsAndNoExceptions_ReturnsTrue()
     {
-        // Arrange
         var buildDropPath = "/test/drop";
         var outputPath = "/test/output.json";
         var specifications = new List<SbomSpecification> { new SbomSpecification("SPDX", "2.2") };
@@ -68,7 +67,6 @@ public async Task ValidateSbomAsync_WithNoErrorsAndNoExceptions_ReturnsTrue()
         var errors = new List<FileValidationResult>();
         var exceptions = new List<Exception>();
 
-        // Setup mocks
         configValidatorsMock.Setup(cv => cv.GetEnumerator()).Returns(new List<ConfigValidator>().GetEnumerator());
 
         configurationMock.Setup(c => c.ManifestInfo).Returns(new ConfigurationSetting<IList<ManifestInfo>>
@@ -94,18 +92,15 @@ public async Task ValidateSbomAsync_WithNoErrorsAndNoExceptions_ReturnsTrue()
             sbomConfigProviderMock.Object,
             fileSystemUtilsMock.Object);
 
-        // Act
         var result = await validator.ValidateSbomAsync(buildDropPath, outputPath, specifications, manifestDirPath);
 
-        // Assert
         Assert.IsTrue(result.IsSuccess);
         Assert.AreEqual(0, result.Errors.Count);
     }
 
     [TestMethod]
     public async Task ValidateSbomAsync_WithErrorsButNoExceptions_ReturnsFalse()
     {
-        // Arrange
         var buildDropPath = "/test/drop";
         var outputPath = "/test/output.json";
         var specifications = new List<SbomSpecification> { new SbomSpecification("SPDX", "2.2") };
@@ -115,11 +110,10 @@ public async Task ValidateSbomAsync_WithErrorsButNoExceptions_ReturnsFalse()
 
         var errors = new List<FileValidationResult>
         {
-            new FileValidationResult { ErrorType = Microsoft.Sbom.Api.Entities.ErrorType.MissingFile, Path = "/test/missing.txt" }
+            new FileValidationResult { ErrorType = ErrorType.MissingFile, Path = "/test/missing.txt" }
         };
         var exceptions = new List<Exception>();
 
-        // Setup mocks
         configValidatorsMock.Setup(cv => cv.GetEnumerator()).Returns(new List<ConfigValidator>().GetEnumerator());
 
         configurationMock.Setup(c => c.ManifestInfo).Returns(new ConfigurationSetting<IList<ManifestInfo>>
@@ -145,18 +139,15 @@ public async Task ValidateSbomAsync_WithErrorsButNoExceptions_ReturnsFalse()
             sbomConfigProviderMock.Object,
             fileSystemUtilsMock.Object);
 
-        // Act
         var result = await validator.ValidateSbomAsync(buildDropPath, outputPath, specifications, manifestDirPath);
 
-        // Assert
         Assert.IsFalse(result.IsSuccess);
         Assert.AreEqual(1, result.Errors.Count);
     }
 
     [TestMethod]
     public async Task ValidateSbomAsync_WithNoErrorsButWithExceptions_ReturnsFalse()
     {
-        // Arrange
         var buildDropPath = "/test/drop";
         var outputPath = "/test/output"; // Directory path, not file path
         var specifications = new List<SbomSpecification> { new SbomSpecification("SPDX", "2.2") };
@@ -170,7 +161,6 @@ public async Task ValidateSbomAsync_WithNoErrorsButWithExceptions_ReturnsFalse()
             new InvalidOperationException("Cannot write to directory path")
         };
 
-        // Setup mocks
         configValidatorsMock.Setup(cv => cv.GetEnumerator()).Returns(new List<ConfigValidator>().GetEnumerator());
 
         configurationMock.Setup(c => c.ManifestInfo).Returns(new ConfigurationSetting<IList<ManifestInfo>>
@@ -196,18 +186,15 @@ public async Task ValidateSbomAsync_WithNoErrorsButWithExceptions_ReturnsFalse()
             sbomConfigProviderMock.Object,
             fileSystemUtilsMock.Object);
 
-        // Act
         var result = await validator.ValidateSbomAsync(buildDropPath, outputPath, specifications, manifestDirPath);
 
-        // Assert
         Assert.IsFalse(result.IsSuccess);
         Assert.AreEqual(0, result.Errors.Count); // No validation errors, but should still fail due to exception
     }
 
     [TestMethod]
     public async Task ValidateSbomAsync_WithBothErrorsAndExceptions_ReturnsFalse()
     {
-        // Arrange
         var buildDropPath = "/test/drop";
         var outputPath = "/test/output";
         var specifications = new List<SbomSpecification> { new SbomSpecification("SPDX", "2.2") };
@@ -217,14 +204,13 @@ public async Task ValidateSbomAsync_WithBothErrorsAndExceptions_ReturnsFalse()
 
         var errors = new List<FileValidationResult>
         {
-            new FileValidationResult { ErrorType = Microsoft.Sbom.Api.Entities.ErrorType.MissingFile, Path = "/test/missing.txt" }
+            new FileValidationResult { ErrorType = ErrorType.MissingFile, Path = "/test/missing.txt" }
         };
         var exceptions = new List<Exception>
         {
             new InvalidOperationException("Cannot write to directory path")
         };
 
-        // Setup mocks
         configValidatorsMock.Setup(cv => cv.GetEnumerator()).Returns(new List<ConfigValidator>().GetEnumerator());
 
         configurationMock.Setup(c => c.ManifestInfo).Returns(new ConfigurationSetting<IList<ManifestInfo>>
@@ -250,10 +236,8 @@ public async Task ValidateSbomAsync_WithBothErrorsAndExceptions_ReturnsFalse()
             sbomConfigProviderMock.Object,
             fileSystemUtilsMock.Object);
 
-        // Act
         var result = await validator.ValidateSbomAsync(buildDropPath, outputPath, specifications, manifestDirPath);
 
-        // Assert
         Assert.IsFalse(result.IsSuccess);
         Assert.AreEqual(1, result.Errors.Count);
     }