-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Labels
bugSomething isn't workingSomething isn't workingpythonPull requests for the Python Semantic KernelPull requests for the Python Semantic KernelstaleIssue is stale because it has been open for a while and has no activityIssue is stale because it has been open for a while and has no activity
Description
Describe the bug
nest_asyncio has been archived by the owner for over a year now.
This has created problems with asyncio support in newer versions of Python and other packages which depend on these newer features. Specifically Python 3.12+ added an optional loop_factory parameter, however the patched version of asyncio.run from nest_asyncio's patched run method doesn't pass-through this keyword argument resulting in errors like:
> asyncio_run(amain(), loop_factory=get_loop_factory())
E TypeError: _patch_asyncio.<locals>.run() got an unexpected keyword argument 'loop_factory'
To Reproduce
Attempt to use newer asyncio features
Expected behavior
Don't patch the stdlib
Screenshots
N/A
Platform
- Language: Python
- Source: pypi v1.24.1, however the dependency still exists in the main branch https://github.com/microsoft/semantic-kernel/blob/main/python/pyproject.toml#L52
- AI model: N/A
- IDE: N/A
- OS: Linux
Additional context
N/A
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpythonPull requests for the Python Semantic KernelPull requests for the Python Semantic KernelstaleIssue is stale because it has been open for a while and has no activityIssue is stale because it has been open for a while and has no activity
Type
Projects
Status
No status