Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: VectorSearch: Ensure AzureAISearch vector search is using async paging. #9077

Open
westey-m opened this issue Oct 3, 2024 · 0 comments
Open

.Net: VectorSearch: Ensure AzureAISearch vector search is using async paging. #9077

westey-m opened this issue Oct 3, 2024 · 0 comments
Assignees
@westey-m
Labels
Ignite memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@westey-m
Copy link
Contributor

westey-m commented Oct 3, 2024

No description provided.

@westey-m westey-m added .NET Issue or Pull requests regarding .NET code memory connector Ignite labels Oct 3, 2024
@westey-m westey-m self-assigned this Oct 3, 2024
@github-actions github-actions bot changed the title .net: VectorSearch: Ensure AzureAISearch vector search is using async paging. .Net: VectorSearch: Ensure AzureAISearch vector search is using async paging. Oct 3, 2024
@westey-m westey-m removed the triage label Oct 3, 2024
@westey-m westey-m mentioned this issue Oct 4, 2024
Merged
4 tasks
westey-m added a commit that referenced this issue Oct 4, 2024
@westey-m
.Net: Use AsynEnumerable search interface for azure ai search. (#9090)
fba0aba 
### Motivation and Context

AzureAISearch has two ways of accessing search results.

### Description

- Switching to IAsyncEnumerable interface to improve performance.
- Switch to AzureOpenAI for integration test embeddings to remove need
for key management.
- Fix small bug in powershell module to create azure ai search test
infra

#9077

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westey-m westey-m

Labels
Ignite memory connector .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evchaki @markwallace-microsoft @westey-m