Skip to content

Commit 25392ea

Browse files
authored
propsheet: add a CodeQL supression comment (#18431)
CodeQL is raising errors when building Visual Studio since they have a dependency on Windows Terminal for our integrated terminal. The issue raised by CodeQL refers to a non-constant string format, but in this case the string comes from a resource file and should be considered constant.
1 parent 8ddb14b commit 25392ea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/propsheet/console.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ void SaveConsoleSettingsIfNeeded(const HWND hwnd)
115115
LoadStringW(ghInstance, IDS_LINKERROR, awchBuffer, ARRAYSIZE(awchBuffer));
116116
StringCchPrintf(szMessage,
117117
ARRAYSIZE(szMessage),
118-
awchBuffer,
118+
awchBuffer, // CodeQL [SM01734] Pulled from a resource file and cannot be a string literal
119119
gpStateInfo->LinkTitle);
120120
LoadStringW(ghInstance, IDS_LINKERRCAP, awchBuffer, ARRAYSIZE(awchBuffer));
121121

0 commit comments

Comments
 (0)