Skip to content

Use synchronous APIs for AppExtensionCatalog #15255

Open
@lhecker

Description

MSFT-43215694 added IAppExtensionCatalog2::FindAll and IAppExtension3::GetPublicFolder. If they release publicly, we should use those in the settings model because extractValueFromTaskWithoutMainThreadAwait is slow, wrong and ✨pain✨ (just that one call to FindAllAsync + await is like 4% of the total startup cost). I personally wouldn't even keep the old code because of that.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-QualityStability, Performance, Etc.Area-SettingsIssues related to settings and customizability, for console or terminalIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions