Cursor width should respect dpi settings

[flyingcat]

Windows Terminal version

1.18.2822.0

Windows build number

10.0.22621.0

Other Software

None

Steps to reproduce

Set display scale to 200% and use the bar cursor.

Expected Behavior

Cursor width should respect dpi settings.

Actual Behavior

On 200% scale monitor, drawing the bar shape cursor use native 1px, not 1 logical pixel (2px). This makes it a little hard to locate, especially in light theme.

screenshots: terminal, WinUI control, browser <textarea>

[lhecker]

I've edited your issue to use the bug template (you're effectively reporting a bug after all). Can you please fill out the two "TODO" comments I left there?

[lhecker]

In AtlasEngine we use half the underline width (thinLineWidth) for the cursor width. This is wrong and it should use options.cursorPixelWidth instead (needs to be funneled into CursorSettings cachedOptions).

Windows Terminal in general always returns 1 in Terminal::GetCursorPixelWidth() which is also wrong because it should use SystemParametersInfoW(SPI_GETCARETWIDTH) instead.