Trigger Redraw Crash

[shmuelie]

Windows Terminal version

1.21.3231.0

Windows build number

10.0.26335.0

Other Software

No response

Steps to reproduce

Unsure 😅

Expected Behavior

To not crash

Actual Behavior

Access Violation exception, see Watson Bucket 20f45815-12a1-7b5a-eadf-5a6297346f30

[zadjii-msft]

internal dupe chain leads to MSFT:54447014,

`ACCESS_VIOLATION_c0000005_Microsoft.Terminal.Control.dll!
Microsoft::Console::VirtualTerminal::StateMachine::ProcessString

[zadjii-msft]

and no hits for that on 1.22. @shmuelie if you use Terminal Preview, does this go away?

[lhecker]

Ah fuck I figured it out. And I typed out such a long message before that...

Here's where we destroy the renderer:

terminal/src/cascadia/TerminalControl/ControlCore.cpp

Lines 227 to 233 in bfab5fd

	ControlCore::~ControlCore()
	{
	Close();
	_renderer.reset();
	_renderEngine.reset();
	}

But during the problematic call we only hold a strong reference to the Terminal, not the ControlCore:

terminal/src/cascadia/TerminalControl/ControlCore.cpp

Lines 197 to 201 in bfab5fd

	if (const auto t = weakTerminal.lock())
	{
	const auto lock = t->LockForWriting();
	t->UpdatePatternsUnderLock();
	}

In other words, the ControlCore gets destroyed while we're holding onto the dysfunctional corpse of a terminal.

[shmuelie]

and no hits for that on 1.22. @shmuelie if you use Terminal Preview, does this go away?

I've not been able to reproduce it since the first crash so can't say

[shmuelie]

Just hit it again today on 1.23.3582.0