Scenario: The Command Palette

[zadjii-msft]

[Original issue: #2046] [Original Spec: #2193] [v2 Spec: #5674] [Spec Addendum 1: #6532]

TODO for initial PR

• The list view items should be clickable
• The list should be sorted by weight, then alphabetically
• There should be stronger weighting for consecutive chars. Case in point: the sett example below
• If you click on a list view item, focus enters the list view item, and then you can't hit enter to select it.
• tests tests tests tests.
• The auto gen names should probably only have the first letter capitalized - I bet if I do that I'll have to revert it during the PR... hmm...

v2.0 Follow-up work

Tasks

• Don't localize command names on the command palette Don't localize command names on the command palette #7039
• Add a setting to display Command Palette ActionMode entries in MRU order Add a setting to display Command Palette ActionMode entries in MRU order #6647
• Add nested commands to the Command Palette Add nested commands to the Command Palette #3994
• Command palette entries should have optional icons Command palette entries should have optional icons #6644
• A nested cmdpal menu should show the parent command above the list of commands A nested cmdpal menu should show the parent command above the list of commands #7265
• Add support for commands iterable on color schemes Add support for commands iterable on color schemes #7329
• Command Palette: Add support for commandline mode Command Palette: Add support for commandline mode #6677
• Make keys in the command palette look like actual keys, like in VS Code Make keys in the command palette look like actual keys, like in VS Code #6645
• Command palette search results should bold the matching text Command palette search results should bold the matching text #6646
• commandPalette keybinding should close the palette when it's open commandPalette keybinding should close the palette when it's open #6679
• Add "recent commands' to Command Palette in commandline mode Add "recent commands' to Command Palette in commandline mode #8296
• Make the Command Line Mode easier to access Make the Command Line Mode easier to access #8322 (make a argument to toggleCommandPalette to go straight to the commandline mode)

Bugs

• _compareCommandNames should use locale-aware string comparisons _compareCommandNames should use locale-aware string comparisons #6953 This is going to be done by Don't localize command names on the command palette #7039 actually.
• Command Palette search algorithm needs to prioritize "longest substring" match, may need multiple passes Command Palette search algorithm needs to prioritize "longest substring" match, may need multiple passes #6693
• [Screen Reader-Command Palette]-Narrator focus is not in sync while navigating using arrow keys in suggestion list after searching for any command. #7911 [Screen Reader-Command Palette]-Narrator focus is not in sync while navigating using arrow keys in suggestion list after searching for any command.
• [Screen Reader-Command Palette]:-Screen reader is not announcing the suggestions when user searches for the commands. #7907 [Screen Reader-Command Palette]:-Screen reader is not announcing the suggestions when user searches for the commands.
• Command palette goes to the top when you go back (<) from a submenu #13457 The "go back" button should pop only one layer of the stack, not go all the way back to the root (Enable moving back to the root level in the command palette #8051 (comment))
• NewTab won't leave the Command Palette NewTab won't leave the Command Palette #7441
• [Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands. #7915 [Visual requirement-Command Palette]-Luminosity ratio is 4.046:1 which is less than 4.5:1 for the shortcut text appended to the Commands.
• [Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open. #7914 [Functional-Command Palette]- User is not able to perform action using shortcuts when command palette is open.
• [Screen Reader-Command Palette]-Narrator focus moves separately onto the shortcut text which is appended to the command. #7913 [Screen Reader-Command Palette]-Narrator focus moves separately onto the shortcut text which is appended to the command.
• [Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item. #7912 [Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item.
• [Functional-Command Palette]- User is not able to move back from the New Tab sub menu as there is no functionality provided to move out of Sub menu. #7910 [Functional-Command Palette]- User is not able to move back from the New Tab sub menu as there is no functionality provided to move out of Sub menu.
• [Screen Reader-Command Palette]-Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate. #7908 [Screen Reader-Command Palette]-Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate.
• Overlapping text in Command Palette submenu after deleting ">" Overlapping text in Command Palette submenu after deleting ">" #10140

Related, but indirectly

• Add an action that runs other actions (action chaining)? Add a shortcut action for executing multiple ShortcutActions #5970
• New icons for UI elements New icons for UI elements #6867
• Add a shortcut action for switching to a specific color scheme Add a shortcut action for switching to a specific color scheme #5401
• Enable sending input to the Terminal with a keybinding Enable sending input to the Terminal with a keybinding #3799
• Megathread: Sometimes, focus moves weirdly Megathread: Sometimes, focus moves weirdly #6680
  • Launching "Find" from Command Palette doesn't focus the search box Launching "Find" from Command Palette doesn't focus the search box #6662

Backlog work

• Consider refactoring CommandPalette + Switcher => LiveFilteringListView Consider refactoring CommandPalette + Switcher => LiveFilteringListView #7285
• Allow commands with user-defined names to be hidden from cmdpal Allow commands with user-defined names to be hidden from cmdpal #7179
• Add auto-suggestion to the Command-Palette wt arguments Add auto-suggestion to the Command-Palette wt arguments #7570
• Code Health: Consider checking we are not in the opening state, by hooking both Opening and Open events
• Code Health: The explicit implementation (in CommandPalette::_lostFocusHandler) can be generalized by checking if the focused element is a descendant of palette
• Additional commands could be previewable Additional commands could be previewable #9818
• Using --window in a wt action should do what you'd expect Using --window in a wt action should do what you'd expect #10146
• Allow binding keys to a nested action, to open the palette directly to it's children Allow binding keys to a nested action, to open the palette directly to it's children #10209
• FR: Command palette commandline mode should store history in ApplicationState #11026
• Keep the Command Palette around after executing a command [Preview] Keep the Command Palette around after executing a command #7011
• Nested previewable commands don't "cancel" when you navigate up the nesting stack Nested previewable commands don't "cancel" when you navigate up the nesting stack #10165
• Preview what actions will be run in commandline mode of the CmdPal Preview what actions will be run in commandline mode of the CmdPal #8344
• Provide realtime commandline parsing feedback in the commandline mode of the command palette Provide realtime commandline parsing feedback in the commandline mode of the command palette #7284
• Allow commands to be previewed in the command palette Allow commands to be previewed in the command palette #6689
• Pressing the right arrow in the commandline mode of the cmdpal should fill in the selected command #11049