Revert "Fix: VSTest bridge - use TestCase.Id for the TestNodeUID (#3270)"

Evangelink · Evangelink · commit 4154368d07da · 2024-07-17T15:10:17.000+02:00
This reverts commit 7c7e601.
diff --git a/src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs b/src/Platform/Microsoft.Testing.Extensions.VSTestBridge/ObjectModel/ObjectModelConverters.cs
@@ -30,7 +30,7 @@ internal static class ObjectModelConverters
     public static TestNode ToTestNode(this TestCase testCase, bool isTrxEnabled, ClientInfo client)
     {
         string testNodeUid = testCase.GetPropertyValue<string>(TestNodeUidProperty, null)
-            ?? testCase.Id.ToString();
+            ?? testCase.FullyQualifiedName;
 
         TestNode testNode = new()
         {
diff --git a/test/UnitTests/Microsoft.Testing.Extensions.VSTestBridge.UnitTests/ObjectModel/ObjectModelConvertersTests.cs b/test/UnitTests/Microsoft.Testing.Extensions.VSTestBridge.UnitTests/ObjectModel/ObjectModelConvertersTests.cs
@@ -29,12 +29,12 @@ public void ToTestNode_WhenTestCaseHasTestNodeUidProperty_TestNodeUidUsesIt()
         Assert.AreEqual("SomeUid", testNode.Uid.Value);
     }
 
-    public void ToTestNode_WhenTestCaseHasNoTestNodeUidProperty_TestNodeUidUsesTestCaseId()
+    public void ToTestNode_WhenTestCaseHasNoTestNodeUidProperty_TestNodeUidUsesFqn()
     {
         TestCase testCase = new("SomeFqn", new("executor://uri", UriKind.Absolute), "source.cs");
         var testNode = testCase.ToTestNode(false, TestClient);
 
-        Assert.AreEqual(testCase.Id.ToString(), testNode.Uid.Value);
+        Assert.AreEqual("SomeFqn", testNode.Uid.Value);
     }
 
     public void ToTestNode_WhenTestCaseHasDisplayName_TestNodeDisplayNameUsesIt()

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ internal static class ObjectModelConverters`
`30`	`30`	`public static TestNode ToTestNode(this TestCase testCase, bool isTrxEnabled, ClientInfo client)`
`31`	`31`	`{`
`32`	`32`	`string testNodeUid = testCase.GetPropertyValue<string>(TestNodeUidProperty, null)`
`33`		`- ?? testCase.Id.ToString();`
	`33`	`+ ?? testCase.FullyQualifiedName;`
`34`	`34`
`35`	`35`	`TestNode testNode = new()`
`36`	`36`	`{`
Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,12 @@ public void ToTestNode_WhenTestCaseHasTestNodeUidProperty_TestNodeUidUsesIt()`
`29`	`29`	`Assert.AreEqual("SomeUid", testNode.Uid.Value);`
`30`	`30`	`}`
`31`	`31`
`32`		`- public void ToTestNode_WhenTestCaseHasNoTestNodeUidProperty_TestNodeUidUsesTestCaseId()`
	`32`	`+ public void ToTestNode_WhenTestCaseHasNoTestNodeUidProperty_TestNodeUidUsesFqn()`
`33`	`33`	`{`
`34`	`34`	`TestCase testCase = new("SomeFqn", new("executor://uri", UriKind.Absolute), "source.cs");`
`35`	`35`	`var testNode = testCase.ToTestNode(false, TestClient);`
`36`	`36`
`37`		`- Assert.AreEqual(testCase.Id.ToString(), testNode.Uid.Value);`
	`37`	`+ Assert.AreEqual("SomeFqn", testNode.Uid.Value);`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`public void ToTestNode_WhenTestCaseHasDisplayName_TestNodeDisplayNameUsesIt()`