Pr review feedbacks

Author: nohwnd

src/Platform/Microsoft.Testing.Extensions.AzureDevOps/AzureDevOpsCommandLineProvider.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using Microsoft.Testing.Extensions.Reporting.Resources;
+using Microsoft.Testing.Extensions.AzureDevOps.Resources;
 using Microsoft.Testing.Platform.CommandLine;
 using Microsoft.Testing.Platform.Extensions;
 using Microsoft.Testing.Platform.Extensions.CommandLine;

src/Platform/Microsoft.Testing.Extensions.AzureDevOps/AzureDevOpsReporter.cs

@@ -1,8 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+using Microsoft.Testing.Extensions.AzureDevOps;
+using Microsoft.Testing.Extensions.AzureDevOps.Resources;
 using Microsoft.Testing.Extensions.Reporting;
-using Microsoft.Testing.Extensions.Reporting.Resources;
 using Microsoft.Testing.Platform;
 using Microsoft.Testing.Platform.CommandLine;
 using Microsoft.Testing.Platform.Extensions.Messages;
@@ -65,10 +66,7 @@ public Task<bool> IsEnabledAsync()
             bool found = _commandLine.TryGetOptionArgumentList(AzureDevOpsCommandLineOptions.AzureDevOpsReportSeverity, out string[]? arguments);
             if (found && arguments?.Length > 0)
             {
-                if (string.Equals(arguments[0], "warning", StringComparison.OrdinalIgnoreCase))
-                {
-                    _severity = "warning";
-                }
+                _severity = arguments[0].ToLowerInvariant();
             }
         }
 
@@ -82,36 +80,27 @@ public async Task ConsumeAsync(IDataProducer dataProducer, IData value, Cancella
             return;
         }
 
-        try
+        if (value is not TestNodeUpdateMessage nodeUpdateMessage)
         {
-            if (value is not TestNodeUpdateMessage nodeUpdateMessage)
-            {
-                return;
-            }
-
-            TestNodeStateProperty nodeState = nodeUpdateMessage.TestNode.Properties.Single<TestNodeStateProperty>();
-
-            switch (nodeState)
-            {
-                case FailedTestNodeStateProperty failed:
-                    await WriteExceptionAsync(failed.Explanation, failed.Exception);
-                    break;
-                case ErrorTestNodeStateProperty error:
-                    await WriteExceptionAsync(error.Explanation, error.Exception);
-                    break;
-                case CancelledTestNodeStateProperty cancelled:
-                    await WriteExceptionAsync(cancelled.Explanation, cancelled.Exception);
-                    break;
-                case TimeoutTestNodeStateProperty timeout:
-                    await WriteExceptionAsync(timeout.Explanation, timeout.Exception);
-                    break;
-            }
-
             return;
         }
-        catch (OperationCanceledException ex) when (ex.CancellationToken == cancellationToken)
+
+        TestNodeStateProperty nodeState = nodeUpdateMessage.TestNode.Properties.Single<TestNodeStateProperty>();
+
+        switch (nodeState)
         {
-            // Do nothing, we're stopping
+            case FailedTestNodeStateProperty failed:
+
+                break;
+            case ErrorTestNodeStateProperty error:
+                await WriteExceptionAsync(error.Explanation, error.Exception);
+                break;
+            case CancelledTestNodeStateProperty cancelled:
+                await WriteExceptionAsync(cancelled.Explanation, cancelled.Exception);
+                break;
+            case TimeoutTestNodeStateProperty timeout:
+                await WriteExceptionAsync(timeout.Explanation, timeout.Exception);
+                break;
         }
 
         return;

src/Platform/Microsoft.Testing.Extensions.AzureDevOps/Microsoft.Testing.Extensions.AzureDevOps.csproj

@@ -2,7 +2,10 @@
 
   <PropertyGroup>
     <TargetFrameworks>netstandard2.0;$(MicrosoftTestingTargetFrameworks)</TargetFrameworks>
-    <RootNamespace>Microsoft.Testing.Extensions.Reporting</RootNamespace>
+
+    <!-- Stay on 1.0.0 alpha while we are dogfooding this extension to see if it is useful. -->
+    <VersionPrefix>1.0.0</VersionPrefix>
+    <PreReleaseVersionLabel>alpha</PreReleaseVersionLabel>
   </PropertyGroup>
 
   <!-- NuGet properties -->
@@ -39,12 +42,6 @@ This package extends Microsoft Testing Platform to provide a Azure DevOps report
     <ProjectReference Include="$(RepoRoot)src\Platform\Microsoft.Testing.Platform\Microsoft.Testing.Platform.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <InternalsVisibleTo Include="Microsoft.Testing.Extensions.VSTestBridge" Key="$(VsPublicKey)" />
-    <InternalsVisibleTo Include="Microsoft.Testing.Extensions.HangDump" Key="$(VsPublicKey)" />
-    <InternalsVisibleTo Include="Microsoft.Testing.Extensions.UnitTests" Key="$(VsPublicKey)" />
-  </ItemGroup>
-
   <ItemGroup>
     <EmbeddedResource Update="Resources\AzureDevOpsResources.resx" GenerateSource="true" />
   </ItemGroup>

src/Platform/Microsoft.Testing.Extensions.AzureDevOps/RootFinder.cs

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-namespace Microsoft.Testing.Extensions.TrxReport.Abstractions;
+namespace Microsoft.Testing.Extensions.AzureDevOps;
 
 internal static class RootFinder
 {