Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable appdomain usage by default #1555

Merged
merged 19 commits into from
Jan 19, 2023
Merged

Disable appdomain usage by default #1555

merged 19 commits into from
Jan 19, 2023

Conversation

engyebrahim
Copy link
Member

fix: #1297

Evangelink
Evangelink previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. It seems that some tests are broken, can you please fix them.

@engyebrahim @Evangelink
simplify a line
405f1f2 
Co-authored-by: Amaury Levé <[email protected]>
@Evangelink Evangelink enabled auto-merge (squash) January 19, 2023 11:26
@Evangelink Evangelink merged commit 02cebe5 into microsoft:main Jan 19, 2023
engyebrahim added a commit that referenced this pull request May 17, 2023
@engyebrahim
Revert "Disable appdomain usage by default (#1555)"
7b9ce8a 
This reverts commit 02cebe5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable appdomain usage by default
2 participants
@engyebrahim @Evangelink