Skip to content

DataModules: rename split parameters #1289

Open
@adamjstewart

Description

@adamjstewart

Summary

We should rename the split parameters we use in data modules.

Rationale

Currently, our modules use val_split_pct and test_split_pct. However, our splitting functions only accept integer lengths or ratios, none of them actually accept percentages.

Implementation

We should use "length" to be consistent with torch.utils.data.random_split. We should either use lengths for methods that accept a variable number of splits or val_length/test_length for methods that differentiate between the two.

Alternatives

Open to suggestions for other names, but want to follow existing standards when possible.

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    backwards-incompatibleChanges that are not backwards compatibledatamodulesPyTorch Lightning datamodules

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions