Dependencies doc is not accurate.

[jiria]

Trident repo does not currently build with the latest stable rust toolchain:

error: struct `LuksDump` is never constructed
   --> crates/trident/src/engine/storage/encryption.rs:289:8
    |
289 | struct LuksDump {
    |        ^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

error: struct `LuksDumpSegment` is never constructed
   --> crates/trident/src/engine/storage/encryption.rs:298:8
    |
298 | struct LuksDumpSegment {
    |        ^^^^^^^^^^^^^^^

error: enum `RaidState` is never used
  --> crates/trident/src/engine/storage/raid.rs:29:17
   |
29 | pub(super) enum RaidState {
   |                 ^^^^^^^^^

error: method `complete_reader` is never used
   --> crates/trident/src/io_utils/file_reader.rs:122:19
    |
 51 | impl FileReader {
    | --------------- method in this implementation
...
122 |     pub(crate) fn complete_reader(&self) -> I...
    |                   ^^^^^^^^^^^^^^^

error: constant `EXTENSION_RELEASE` is never used
  --> crates/trident/src/subsystems/extensions/mod.rs:32:7
   |
32 | const EXTENSION_RELEASE: &str = "extension-rel...
   |       ^^^^^^^^^^^^^^^^^

error: constant `SYSEXT_EXTENSION_RELEASE_DIRECTORY` is never used
  --> crates/trident/src/subsystems/extensions/mod.rs:35:7
   |
35 | const SYSEXT_EXTENSION_RELEASE_DIRECTORY: &str...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: constant `CONFEXT_EXTENSION_RELEASE_DIRECTORY` is never used
  --> crates/trident/src/subsystems/extensions/mod.rs:37:7
   |
37 | const CONFEXT_EXTENSION_RELEASE_DIRECTORY: &st...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: constant `EXTENSION_IMAGE_STAGING_DIRECTORY` is never used
  --> crates/trident/src/subsystems/extensions/mod.rs:40:7
   |
40 | const EXTENSION_IMAGE_STAGING_DIRECTORY: &str ...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: struct `ExtensionData` is never constructed
  --> crates/trident/src/subsystems/extensions/mod.rs:43:12
   |
43 | pub struct ExtensionData {
   |            ^^^^^^^^^^^^^

error: enum `ExtensionType` is never used
  --> crates/trident/src/subsystems/extensions/mod.rs:69:10
   |
69 | pub enum ExtensionType {
   |          ^^^^^^^^^^^^^

error: struct `ExtensionsSubsystem` is never constructed
  --> crates/trident/src/subsystems/extensions/mod.rs:84:12
   |
84 | pub struct ExtensionsSubsystem {
   |            ^^^^^^^^^^^^^^^^^^^

error: methods `populate_extensions`, `populate_extensions_inner`, `create_directories`, and `set_up_extensions` are never used
   --> crates/trident/src/subsystems/extensions/mod.rs:124:8
    |
123 | impl ExtensionsSubsystem {
    | ------------------------ methods in this implementation
124 |     fn populate_extensions(
    |        ^^^^^^^^^^^^^^^^^^^
...
161 |     fn populate_extensions_inner(
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^
...
271 |     fn create_directories(&self, mount_path: ...
    |        ^^^^^^^^^^^^^^^^^^
...
310 |     fn set_up_extensions(
    |        ^^^^^^^^^^^^^^^^^

error: function `check_for_existing_image` is never used
   --> crates/trident/src/subsystems/extensions/mod.rs:407:4
    |
407 | fn check_for_existing_image(ext: &Extension, ...
    |    ^^^^^^^^^^^^^^^^^^^^^^^^

error: function `attach_device_and_mount` is never used
   --> crates/trident/src/subsystems/extensions/mod.rs:417:4
    |
417 | fn attach_device_and_mount(image_file_path: &...
    |    ^^^^^^^^^^^^^^^^^^^^^^^

error: function `detach_device_and_unmount` is never used
   --> crates/trident/src/subsystems/extensions/mod.rs:452:4
    |
452 | fn detach_device_and_unmount(device_path: Str...
    |    ^^^^^^^^^^^^^^^^^^^^^^^^^

error: constant `EXTENSION_RELEASE_PREFIX` is never used
  --> crates/trident/src/subsystems/extensions/release.rs:21:7
   |
21 | const EXTENSION_RELEASE_PREFIX: &str = formatc...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^

error: function `read_extension_release` is never used
  --> crates/trident/src/subsystems/extensions/release.rs:24:15
   |
24 | pub(crate) fn read_extension_release(
   |               ^^^^^^^^^^^^^^^^^^^^^^

error: hiding a lifetime that's elided elsewhere is confusing
   --> crates/trident/src/osimage/mod.rs:140:38
    |
140 | ...em(&self, path: &Path) -> Option<OsImageFileSystem> {
    |       ^^^^^                         ----------------- the same lifetime is hidden here
    |       |
    |       the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
    = note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
help: use `'_` for type paths
    |
140 |     pub(crate) fn path_to_filesystem(&self, path: &Path) -> Option<OsImageFileSystem<'_>> {
    |                                                                                     ++++

error: hiding a lifetime that's elided elsewhere is confusing
   --> crates/trident/src/osimage/mod.rs:156:34
    |
156 | ...em(&self) -> Result<OsImageFileSystem, Err...
    |       ^^^^^            ----------------- the same lifetime is hidden here
    |       |
    |       the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
156 |     pub(crate) fn esp_filesystem(&self) -> Result<OsImageFileSystem<'_>, Error> {
    |                                                                    ++++

error: hiding a lifetime that's elided elsewhere is confusing
   --> crates/trident/src/osimage/mod.rs:165:31
    |
165 | ...ms(&self) -> Box<dyn Iterator<Item = OsImageFileSystem> +...
    |       ^^^^^ the lifetime is elided here ----------------- the same lifetime is hidden here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
165 |     pub(crate) fn filesystems(&self) -> Box<dyn Iterator<Item = OsImageFileSystem<'_>> + '_> {
    |                                                                                  ++++

error: hiding a lifetime that's elided elsewhere is confusing
   --> crates/trident/src/osimage/mod.rs:174:35
    |
174 | ...em(&self) -> Option<OsImageFileSystem> {
    |       ^^^^^            ----------------- the same lifetime is hidden here
    |       |
    |       the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
174 |     pub(crate) fn root_filesystem(&self) -> Option<OsImageFileSystem<'_>> {
    |                                                                     ++++

error: hiding a lifetime that's elided elsewhere is confusing
  --> crates/trident/src/osimage/cosi/mod.rs:88:34
   |
88 | ...em(&self) -> Result<OsImageFileSystem, Erro...
   |       ^^^^^            ----------------- the same lifetime is hidden here
   |       |
   |       the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
88 |     pub(super) fn esp_filesystem(&self) -> Result<OsImageFileSystem<'_>, Error> {
   |                                                                    ++++

error: hiding a lifetime that's elided elsewhere is confusing
   --> crates/trident/src/osimage/cosi/mod.rs:102:31
    |
102 | ...ms(&self) -> impl Iterator<Item = OsImageFileSystem> {
    |       ^^^^^                          ----------------- the same lifetime is hidden here
    |       |
    |       the lifetime is elided here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
    |
102 |     pub(super) fn filesystems(&self) -> impl Iterator<Item = OsImageFileSystem<'_>> {
    |                                                                               ++++

error: could not compile `trident` (lib) due to 23 previous errors
make: *** [Makefile:24: check] Error 101

Furthermore, the dependencies is missing instructions for black and .cargo/config.

[jiria]

It would be nice to be more specific re rust/golang/docker instructions for at least Ubuntu, since other packages are already spelled out.

[jiria]

This also fails to install:

cargo install cargo-nextest --locked

$ cargo install cargo-nextest --locked
warning: both /workspace/trident/.cargo/config and /workspace/trident/.cargo/config.toml exist. Using /workspace/trident/.cargo/config
Updating crates.io index
error: cannot install package cargo-nextest 0.9.108, it requires rustc 1.87 or newer, while the currently active rustc version is 1.85.1
cargo-nextest 0.9.100 supports rustc 1.85

[jiria]

And /bin/sh: 1: grcov: not found

[jiria]

And dependencies for virtdeploy are missing.

[jiria]

And yq for make run-netlaunch-sample.