Commit 38de4f5
authored
fix(http-server-csharp): resolve ASP.NET Core MVC types in
## Fixes
Fixes #11445
## Problem
Controllers generated by `@typespec/http-server-csharp` failed to
compile when the service namespace begins with `Microsoft.` (as every
ARM resource provider does). `ControllerBase` and `IActionResult` were
emitted as raw string identifiers, so under a namespace like
`Microsoft.Contoso.Controllers` they became **bare, unresolved
identifiers** — there was no `using Microsoft.AspNetCore.Mvc;` and Alloy
could not qualify them relative to the shared `Microsoft` ancestor
namespace.
## Fix
Emit `ControllerBase` and `IActionResult` as `Microsoft.AspNetCore.Mvc`
**library references** (like `[ApiController]` already was), so Alloy's
name resolution handles them in every namespace:
- **Plain namespace** (e.g. `Contoso`): a single `using
Microsoft.AspNetCore.Mvc;` is added and the short names `ControllerBase`
/ `IActionResult` / `[ApiController]` are used.
- **`Microsoft.*` namespace** (e.g. `Microsoft.Contoso`): the types are
qualified relative to the enclosing `Microsoft` namespace —
`AspNetCore.Mvc.ControllerBase`, `Task<AspNetCore.Mvc.IActionResult>`,
`[AspNetCore.Mvc.ApiControllerAttribute]` — all of which resolve and
compile.
Symbols dedupe through Alloy's `using` set, so no duplicate `using`
directives are produced.
## Changes
- `src/utils/csharp-libs.tsx`: add `ControllerBase` and `IActionResult`
to the `AspNetMvc` library.
- `src/components/controllers/controllers.tsx`:
`baseType={AspNetMvc.ControllerBase}`.
- `src/components/controller-action/controller-action.tsx`:
`returns={code\`Task<${AspNetMvc.IActionResult}>\`}`.
## Tests
Added `.toRenderTo` regression tests in
`src/components/controllers/controllers.test.tsx` covering both a plain
namespace and a `Microsoft.*` namespace. Full package suite passes (205
tests).Microsoft.* namespaces (#11458)1 parent 6b0018d commit 38de4f5
6 files changed
Lines changed: 118 additions & 8 deletions
File tree
- .chronus/changes
- packages/http-server-csharp
- src
- components
- controller-action
- controllers
- utils
- test
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
| 238 | + | |
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| |||
Lines changed: 104 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
23 | 28 | | |
24 | 29 | | |
25 | | - | |
| 30 | + | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| |||
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
35 | | - | |
| 40 | + | |
36 | 41 | | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
40 | 45 | | |
| 46 | + | |
| 47 | + | |
41 | 48 | | |
42 | | - | |
| 49 | + | |
| 50 | + | |
43 | 51 | | |
44 | 52 | | |
45 | 53 | | |
| |||
74 | 82 | | |
75 | 83 | | |
76 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
1 | 4 | | |
2 | 5 | | |
3 | 6 | | |
| |||
0 commit comments