[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios#10896
Open
Copilot wants to merge 4 commits into
Open
[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios#10896Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test case for Python SDK Spector mock API
[python] Add mock_api coverage for single-discriminator no-subtypes scenario
Jun 4, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
…-python-sdk-spector # Conflicts: # packages/http-client-python/package-lock.json Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Contributor
Author
msyyc
reviewed
Jun 9, 2026
| - "@typespec/http-client-python" | ||
| --- | ||
|
|
||
| Add sync and async mock_api tests for the single-discriminator no-subtypes Spector scenario from http-specs. |
Contributor
There was a problem hiding this comment.
follow https://github.com/microsoft/typespec/blob/main/.github/skills/python-sdk-spector-mock-api-tests/SKILL.md to add test case for #10841.
NOTE: there is already some test added but you miss some. @copilot
Contributor
Author
There was a problem hiding this comment.
Added the missing coverage. PR #10841 introduced three scenarios:
Type_Model_Inheritance_SingleDiscriminator_get/putNoSubtypesModel— already covered.Parameters_BodyRoot_nested— now covered (sync + async, shared) intest_parameters_body_root.py/asynctests/test_parameters_body_root_async.py. Validated locally against the Spector mock server (both pass).Parameters_Query_SpecialChar_dollarSign— not added because of an upstream spec inconsistency:main.tspdeclares@route("/dollarSign")(andspec-summary.mddocuments/dollarSign), butmockapi.tsregisters the endpoint at/parameters/query/special-char/dollar-sign. The mock server only serves/dollar-sign, while the generated SDK correctly calls/dollarSign, so the test 404s. This needs a fix inhttp-specs(align themockapi.tsuri with the route) before SDK coverage can pass. Let me know if you'd like me to proceed once that's corrected.
Done in 19224f7.
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Copilot
AI
changed the title
[python] Add mock_api coverage for single-discriminator no-subtypes scenario
[python] Add mock_api coverage for single-discriminator no-subtypes and body-root nested scenarios
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds python mock API coverage for new Spector scenarios introduced by the cross-language spec updates (PR #10841): a discriminated model with no declared subtypes, and a
@bodyRootparameter nested inside a wrapper model. The PR extends existing single-discriminator tests in both sync and async suites, adds new shared body-root tests, and aligns local spec inputs to a version that contains the scenarios.Test coverage: single-discriminator no-subtypes (shared sync/async)
get_no_subtypes_model()put_no_subtypes_model(...)Fishmodel assertions to validate the expected wire payload shape (kind,size).Test coverage: body-root nested (shared sync/async)
test_parameters_body_root.pyandasynctests/test_parameters_body_root_async.py) covering thenested(...)operation with aBodyRootModel(category,link_type,was_successful).Spec dependency update for scenario availability
@typespec/http-specsinpackages/http-client-python/package.json(and lockfile) to a version containing the new scenario definitions used by regeneration.Change tracking
internalentry for@typespec/http-client-python.