Resolve diagnostic node mapping for value entities in getNodeForTarget

[Copilot]

Diagnostics were resolving targets as if all entities were types, which could surface the wrong source location when the target was a value (notably function values). This change makes node extraction entity-aware so diagnostics map to the actual originating node for values and mixed constraints.

• Problem context

  • TypeSpecDiagnosticTarget includes Entity, but getNodeForTarget only handled symbols/nodes/types, so value entities could be rendered with misleading locations.

• Compiler change: entity-aware target resolution

  • getNodeForTarget now explicitly handles entityKind branches:
    • Type → target.node
    • Value → value node (when present) with fallback to target.type.node
    • MixedParameterConstraint → node ?? type.node ?? valueType.node (documented precedence)
    • Indeterminate → target.type.node
  • Added getValueNode(value) to centralize node extraction for value kinds that carry syntax nodes (Function, ObjectValue, ArrayValue).

• Coverage added

  • Extended core diagnostics tests to cover:
    • function value node preference
    • value → type-node fallback
    • object value node handling
    • mixed-constraint precedence
    • indeterminate entity node resolution

if ("entityKind" in target) {
  switch (target.entityKind) {
    case "Type":
      return target.node;
    case "Value":
      return getValueNode(target) ?? target.type.node;
    case "MixedParameterConstraint":
      return target.node ?? target.type?.node ?? target.valueType?.node;
    case "Indeterminate":
      return target.type.node;
  }
}

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/compiler@10921

npm i https://pkg.pr.new/@typespec/html-program-viewer@10921

commit: 6ff6ca5

[azure-sdk-automation]

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension