Fix command line too long when sending to GitHub dependency graph (#1144)

Author: klalumiere

include/vcpkg/base/downloads.h

@@ -36,7 +36,8 @@ namespace vcpkg
                                     View<std::pair<std::string, Path>> url_pairs,
                                     View<std::string> headers);
 
-    bool send_snapshot_to_api(const std::string& github_token,
+    bool send_snapshot_to_api(const Filesystem& fs,
+                              const std::string& github_token,
                               const std::string& github_repository,
                               const Json::Object& snapshot);
     ExpectedL<int> put_file(const ReadOnlyFilesystem&,

src/vcpkg/base/downloads.cpp

@@ -12,6 +12,7 @@
 #include <vcpkg/base/system.process.h>
 #include <vcpkg/base/system.proxy.h>
 #include <vcpkg/base/util.h>
+#include <vcpkg/base/uuid.h>
 
 #include <vcpkg/commands.version.h>
 #include <vcpkg/metrics.h>
@@ -521,7 +522,8 @@ namespace vcpkg
         return ret;
     }
 
-    bool send_snapshot_to_api(const std::string& github_token,
+    bool send_snapshot_to_api(const Filesystem& fs,
+                              const std::string& github_token,
                               const std::string& github_repository,
                               const Json::Object& snapshot)
     {
@@ -538,7 +540,13 @@ namespace vcpkg
         cmd.string_arg("-H").string_arg("X-GitHub-Api-Version: 2022-11-28");
         cmd.string_arg(
             Strings::concat("https://api.github.com/repos/", github_repository, "/dependency-graph/snapshots"));
-        cmd.string_arg("-d").string_arg(Json::stringify(snapshot));
+
+        const auto tmp_dir = fs.create_or_get_temp_directory(VCPKG_LINE_INFO);
+        const auto unique_file_name = fmt::format("dependency_snapshot_{}.json", generate_random_UUID());
+        const auto snapshot_file_path = tmp_dir / unique_file_name;
+        fs.write_contents(snapshot_file_path, Json::stringify(snapshot), VCPKG_LINE_INFO);
+
+        cmd.string_arg("-d").string_arg(fmt::format("@{}", snapshot_file_path));
         int code = 0;
         auto result = cmd_execute_and_stream_lines(cmd, [&code](StringView line) {
             if (Strings::starts_with(line, guid_marker))

src/vcpkg/commands.set-installed.cpp

@@ -193,7 +193,7 @@ namespace vcpkg::Commands::SetInstalled
             bool s = false;
             if (snapshot.has_value() && args.github_token.has_value() && args.github_repository.has_value())
             {
-                s = send_snapshot_to_api(*args.github_token.get(), *args.github_repository.get(), *snapshot.get());
+                s = send_snapshot_to_api(fs, *args.github_token.get(), *args.github_repository.get(), *snapshot.get());
                 if (s)
                 {
                     msg::println(msgDependencyGraphSuccess);