Skip to content

Commit e74e98a

Browse files
authored
Merge branch 'microsoft:master' into icu
2 parents e783b55 + d92484e commit e74e98a

23 files changed

Lines changed: 141 additions & 86 deletions

.github/skills/shared/review-vcpkg-pr-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ The report considers the following in particular:
5050
11. No vendored third-party code is used during the build. List any well-known third-party libraries found in extracted sources.
5151
12. The versioning scheme in vcpkg.json matches the packaged content.
5252
13. The license declaration in vcpkg.json matches the content installed by installing a port. Note that content in sources may be skipped in settings in portfile.cmake. If a feature in vcpkg.json installs additional content under a different license, then the feature should have a separate license declared. Treat `"license": null` as an intentional declaration that no SPDX expression is available; inspect the copyright file and installed content instead. When the only available license or copyright notice for a library appears in its header files, patches pass one representative header containing the notice directly to `vcpkg_install_copyright(FILE_LIST ...)`. Do not create a separate text file that copies or extracts the notice from the header.
53-
14. The generated "usage text" is brief and accurate.
53+
14. The generated "usage text" is brief and accurate. Custom usage files are only used if not substantially identical to generated usage, which can be checked with `vcpkg print-usage <port> [--generated]`.
5454
15. Ports do not use system-modifying applications such as sudo, apt, or brew.
5555
16. Changes in shared build helpers or `scripts/cmake` that affect many ports need explicit justification for why a global change is necessary. Do not edit frozen `scripts/cmake` helpers when a corresponding `vcpkg-*` helper port exists; require ports to adopt the helper port instead.
5656
17. Ports use `vcpkg_check_linkage` over mutating `VCPKG_LIBRARY_LINKAGE` directly.
57-
18. Files in the port directory have LF line endings.
57+
18. Non-patch files in the port directory have LF line endings. Patch files are normally LF-only; CRLF is acceptable in hunk lines that patch CRLF content, as produced by `git diff --output` (ignoring differences in the `index` extended header).
5858
19. Anything else in the changeset that conflicts with the maintainer guide.
5959

6060
Read the PR description and conversation. Treat them as explanations, motivation, and questions to answer.

ports/armadillo/dependencies.patch

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
diff --git a/CMakeLists.txt b/CMakeLists.txt
2-
index 5b27e3c..78d3952 100644
2+
index ee702f83..c29fe1d2 100644
33
--- a/CMakeLists.txt
44
+++ b/CMakeLists.txt
5-
@@ -260,7 +260,6 @@ message(STATUS "*** Looking for external libraries")
5+
@@ -273,7 +273,6 @@ message(STATUS "*** Looking for external libraries")
66
## Find LAPACK and BLAS libraries, or their optimised versions
77
##
88

99
-set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake_aux/Modules/")
1010

1111
if(APPLE)
1212
message(STATUS "Detected macOS")
13-
@@ -331,11 +330,16 @@ else()
13+
@@ -344,11 +343,16 @@ else()
1414
set(FlexiBLAS_FOUND false)
1515
endif()
1616

@@ -27,19 +27,19 @@ index 5b27e3c..78d3952 100644
2727

2828
message(STATUS "FlexiBLAS_FOUND = ${FlexiBLAS_FOUND}" )
2929
message(STATUS " MKL_FOUND = ${MKL_FOUND}" )
30-
@@ -449,7 +453,6 @@ else()
30+
@@ -464,7 +468,6 @@ else()
3131
endif()
3232

3333

3434
-include(ARMA_FindARPACK)
3535
message(STATUS "ARPACK_FOUND = ${ARPACK_FOUND}")
3636

3737
if(ARPACK_FOUND)
38-
@@ -457,7 +460,6 @@ if(ARPACK_FOUND)
38+
@@ -472,7 +475,6 @@ if(ARPACK_FOUND)
3939
set(ARMA_LIBS ${ARMA_LIBS} ${ARPACK_LIBRARY})
4040
endif()
4141

42-
-include(ARMA_FindSuperLU5)
42+
-include(ARMA_FindSuperLU)
4343
message(STATUS "SuperLU_FOUND = ${SuperLU_FOUND}")
4444

4545
if(SuperLU_FOUND)

ports/armadillo/portfile.cmake

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ vcpkg_from_sourceforge(
44
OUT_SOURCE_PATH SOURCE_PATH
55
REPO arma
66
FILENAME "armadillo-${VERSION}.tar.xz"
7-
SHA512 E5983B109242F522561A16A4C5F095F25A8F5262E9E6A5C8AC9D7FA48B1F1B1C3A2E48D5671EB02C478B378BC1759BACE9AC061434C42E7338C0C2D21779F607
7+
SHA512 f605678837c821b39273f64750e6398e0feff9ca4ec507a19712436ba8c0d07ab9901ffa01b96fe77a700ea49a6c19e7a75e66bfd9127c5a09bb20bfba3bbf68
88
PATCHES
99
cmake-config.patch
1010
dependencies.patch
@@ -53,4 +53,8 @@ vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/armadillo_bits/config.hpp"
5353

5454
file(COPY "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
5555
file(COPY "${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
56-
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE.txt")
56+
vcpkg_install_copyright(
57+
FILE_LIST
58+
"${SOURCE_PATH}/LICENSE.txt"
59+
"${SOURCE_PATH}/NOTICE.txt"
60+
)

ports/armadillo/vcpkg.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"name": "armadillo",
3-
"version": "14.4.1",
4-
"port-version": 1,
3+
"version": "15.4.2",
54
"description": "Armadillo is a high quality linear algebra library (matrix maths) for the C++ language, aiming towards a good balance between speed and ease of use",
65
"homepage": "https://arma.sourceforge.net/",
76
"license": "Apache-2.0",

ports/aws-c-sdkutils/portfile.cmake

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ vcpkg_from_github(
22
OUT_SOURCE_PATH SOURCE_PATH
33
REPO awslabs/aws-c-sdkutils
44
REF "v${VERSION}"
5-
SHA512 4ca56a50f2d13d1753ecb5fa78697b9ed25dd0304723ee2c95845d873125524f274ea557a2a9d0472cbe6e4e44facc56c5b2487ffaf1801ab7f3e0f4083f678f
5+
SHA512 46db6a4bc6746311d5e5eeb5888b4dd22513fe2e17c147ee40d649dea8db86a9b229e5815911fc8ae5e8f716be1df6cf4915c646ab842d5bc39f7a9ed5c36976
66
HEAD_REF main
77
)
88

@@ -29,4 +29,8 @@ file(REMOVE_RECURSE
2929

3030
vcpkg_copy_pdbs()
3131

32-
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
32+
vcpkg_install_copyright(
33+
FILE_LIST
34+
"${SOURCE_PATH}/LICENSE"
35+
"${SOURCE_PATH}/NOTICE"
36+
)

ports/aws-c-sdkutils/vcpkg.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "aws-c-sdkutils",
3-
"version": "0.2.8",
3+
"version": "0.2.9",
44
"description": "C99 library implementing AWS SDK specific utilities. Includes utilities for ARN parsing, reading AWS profiles, etc...",
55
"homepage": "https://github.com/awslabs/aws-c-sdkutils",
66
"license": "Apache-2.0",
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
diff --git a/lib/base64.h b/lib/base64.h
2+
index 0a4ad0e220d..9c8ea95d045 100644
3+
--- a/lib/base64.h
4+
+++ b/lib/base64.h
5+
@@ -18,11 +18,8 @@
6+
#ifndef BOINC_BASE64_H
7+
#define BOINC_BASE64_H
8+
9+
-#ifndef _WIN32
10+
-#include <cstdio>
11+
-#include <cstdlib>
12+
+#include <stddef.h>
13+
#include <string>
14+
-#endif
15+
16+
class InvalidBase64Exception
17+
{

ports/boinc/portfile.cmake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ vcpkg_from_github(
44
OUT_SOURCE_PATH SOURCE_PATH
55
REPO BOINC/boinc
66
REF "client_release/${MAJOR_MINOR}/${VERSION}"
7-
SHA512 68b008d8208fe8077726ec49657b76a76f3c30b3ac247cd09cf7c97b2cde126f92048fc812bf2df4cca343566654021f4a0dadb02db0ec8b91d57868cea2387d
7+
SHA512 e3984f66e37f8d677696a15b9c6fa363e55c6cd4895a0d39580f2cae02049c1ac494c70603ef5b5d15df1228d7bd322fffdbde6a2cf5ec60a3c968e82dcd647a
88
HEAD_REF master
9+
PATCHES
10+
fix-base64-header.patch # https://github.com/BOINC/boinc/pull/7205
911
)
1012

1113
file(COPY ${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt DESTINATION ${SOURCE_PATH})

ports/boinc/vcpkg.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "boinc",
3-
"version": "8.2.13",
3+
"version": "8.2.15",
44
"description": "Open-source software for volunteer computing and grid computing.",
55
"homepage": "https://boinc.berkeley.edu/",
66
"license": "LGPL-3.0-or-later",

ports/crashcatch/portfile.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ vcpkg_from_github(
44
OUT_SOURCE_PATH SOURCE_PATH
55
REPO keithpotz/CrashCatch
66
REF "v${VERSION}"
7-
SHA512 ba3f431b1c1da9f8ead4038ff8073df3010394ce84a6976ba6b9e9f50842a3aacb367b443a92fef75317ee49cf08384a39d76b944bf1e2735d3e2a3647c63f01
7+
SHA512 1f7b8a75673abf74ee417fbc679bb293a04dc48f1c4a17fd69db0b7e260a30575564c4f406d98ab37478a9515b46cdc7b044e3050462a1b1384c0f95019b40da
88
HEAD_REF main
99
PATCHES
1010
fix-disable-examples-tests.patch

0 commit comments

Comments
 (0)