[vcpkg] vcpkg fails if the path contains []s (applocal.ps1 tries to copy to C:\windows\SysWOW64\windowspowershell\v1.0\ )

[erri120]

Describe the bug
vcpkg tries to copy dlls to C:\windows\SysWOW64\windowspowershell\v1.0\:

Scanning dependencies of target U1
[ 50%] Building CXX object CMakeFiles/U1.dir/main.cpp.obj
main.cpp
[100%] Linking CXX executable U1.exe
Split-Path : Cannot bind argument to parameter 'Path' because it is null.
At M:\Projects\vcpkg\scripts\buildsystems\msbuild\applocal.ps1:40 char:39
+     $baseTargetBinaryDir = Split-Path $baseBinaryPath -parent
+                                       ~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Split-Path], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.SplitPathCo 
   mmand
 
Split-Path : Cannot bind argument to parameter 'Path' because it is null.
At M:\Projects\vcpkg\scripts\buildsystems\msbuild\applocal.ps1:58 char:35
+     $targetBinaryDir = Split-Path $targetBinaryPath -parent
+                                   ~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Split-Path], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.SplitPathCo 
   mmand
 
Copy-Item : Access to the path 'C:\windows\SysWOW64\windowspowershell\v1.0\opencv_highguid.dll' is denied.
At M:\Projects\vcpkg\scripts\buildsystems\msbuild\applocal.ps1:29 char:9
+         Copy-Item "$SourceDir\$targetBinaryName" $targetBinaryDir
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (M:\Projects\vcp...cv_highguid.dll:FileInfo) [Copy-Item], Unauthorized 
   AccessException
    + FullyQualifiedErrorId : CopyFileInfoItemUnauthorizedAccessError,Microsoft.PowerShell.Commands.CopyItemCommand
 
Copy-Item : Access to the path 'C:\windows\SysWOW64\windowspowershell\v1.0\opencv_imgcodecsd.dll' is denied.
At M:\Projects\vcpkg\scripts\buildsystems\msbuild\applocal.ps1:29 char:9
+         Copy-Item "$SourceDir\$targetBinaryName" $targetBinaryDir
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (M:\Projects\vcp..._imgcodecsd.dll:FileInfo) [Copy-Item], Unauthorized 
   AccessException
    + FullyQualifiedErrorId : CopyFileInfoItemUnauthorizedAccessError,Microsoft.PowerShell.Commands.CopyItemCommand
 
Copy-Item : Access to the path 'C:\windows\SysWOW64\windowspowershell\v1.0\opencv_cored.dll' is denied.
At M:\Projects\vcpkg\scripts\buildsystems\msbuild\applocal.ps1:29 char:9
+         Copy-Item "$SourceDir\$targetBinaryName" $targetBinaryDir
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (M:\Projects\vcp...pencv_cored.dll:FileInfo) [Copy-Item], Unauthorized 
   AccessException
    + FullyQualifiedErrorId : CopyFileInfoItemUnauthorizedAccessError,Microsoft.PowerShell.Commands.CopyItemCommand
 
[100%] Built target U1

Build finished

The build itself is successful, the libraries were linked but vcpkg for some reason wants to copy the dlls to this windows path instead of the output path. Running the resulting exe will get you

The code execution cannot proceed because SOMELIB was not found. Reinstalling the program may fix this problem.

Environment

• Windows
• Fails with both VS and CLion

To Reproduce

1. Create a new CMake project
2. Install some packages (opencv in my case)
3. Code
4. Build
5. Error

Expected behavior
No failure. Don't even understand why vcpkg would want to copy the files to this directory. Should copy files to the output directory, no?

CMakeLists.txt:

cmake_minimum_required(VERSION 3.17)
project(U1)
set(CMAKE_CXX_STANDARD 14)

find_package(OpenCV REQUIRED)
add_executable(U1 main.cpp)
target_link_libraries(U1 ${OpenCV_LIBS})

[JackBoosY]

Maybe your find_package is incorrect.
It should be:

find_package(OpenCV CONFIG REQUIRED)
target_link_libraries(U1 opencv_core)

[erri120]

Nope, like I said it builds fine and linking also works. The only problem is vcpkg that tries to copy the dll files to a system folder and not to the output folder.

[JackBoosY]

cc @BillyONeal

[BillyONeal]

Split-Path : Cannot bind argument to parameter 'Path' because it is null.

is the real error. We're trying to say that the file(s) in question are to go into $SourcePath but that's getting set to empty string since we failed to parse something earlier in the line.

The strange thing is that applocal.ps1 is running at all -- that's only for vcpkg integrate install usage, not for cmake customers (at this time). Did you mint an msbuild project with cmake and open that with VS and that's what triggered it?

[erri120]

Did you mint an msbuild project with cmake and open that with VS and that's what triggered it?

I just created a new CMake project with CLion. This happens regardless of IDE used (CLion, VS and prob also VS Code but haven't tested with that)

[BillyONeal]

Hmmmm that's strange; cmake shouldn't ever be calling applocal.ps1, that's only called by the msbuild integration pieces.

Can you show the specific invocation you're seeing, similar to the following?

**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.7.7
** Copyright (c) 2020 Microsoft Corporation
**********************************************************************

C:\Dev>cd demo

C:\Dev\demo>type .\main.cpp
#include <stdio.h>

int main() {
        puts("Hello World!");
}

C:\Dev\demo>type .\CMakeLists.txt
cmake_minimum_required(VERSION 3.17)
project(U1)
set(CMAKE_CXX_STANDARD 14)

find_package(OpenCV REQUIRED)
add_executable(U1 main.cpp)
target_link_libraries(U1 ${OpenCV_LIBS})

C:\Dev\demo>..\vcpkg\vcpkg.exe install opencv
Computing installation plan...
The following packages are already installed:
    opencv[core,dnn,jpeg,opengl,png,tiff,webp]:x86-windows
Package opencv:x86-windows is already installed

Total elapsed time: 202.5 us


C:\Dev\demo>cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE=C:\Dev\vcpkg\scripts\buildsystems\vcpkg.cmake -B C:\Dev\demobuild -S .-- The C compiler identification is MSVC 19.27.29112.0
-- The CXX compiler identification is MSVC 19.27.29112.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx86/x86/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx86/x86/cl.exe - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx86/x86/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.27.29110/bin/Hostx86/x86/cl.exe - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found OpenCV: C:/Dev/vcpkg/installed/x86-windows (found version "4.3.0")
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Dev/demobuild

C:\Dev\demo>ninja -C C:\Dev\demobuild
ninja: Entering directory `C:\Dev\demobuild'
[2/2] Linking CXX executable U1.exe

C:\Dev\demo>

[erri120]

Hmm looks like this is a path problem. This problem only occurred when the path contained [,],, and some spaces. Path m:/Projects/opencvtest worked but path C:/Users/erri/Documents/School/[n] foo, bar/foo/bar/U1 did not

[JackBoosY]

@BillyONeal I think it's a vcpkg bug.